Icecast dev - Sep 2008 - [libshout] Add mime/content-type parameter

Hi all !

While trying to read ogg data from various audio players, it sometimes appear 
that the player needs a different mime type than libshout's 
default, "application/ogg". For instance, I already saw:
  "application/x-ogg";"audio/x-ogg"

Currently, libshout has a built-in Content-Type parameter, that is 
set according to the given format integer.

I would like to propose a backward compatible patch that adds a mime
parameter to shout_t and the corresponding set/get functions.

This parameter is set to default values when calling set_format, so the 
behaviour is 100% backward compatible, only it adds more flexibility to 
libshout.

What do you think ?


Romain
-------------- next part --------------
A non-text attachment was scrubbed...
Name: shout_mime_param.patch
Type: text/x-diff
Size: 3586 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/icecast-dev/attachments/20080920/f4069344/attachment.patch

It seems like a fine patch, but you need to revise it because
video/ogg and audio/ogg are registered media types for Ogg streams
too.  This, of course, is something recent, so don't blame yourself if
you haven't heard.

For those who need more details on what media type to use on what
situation, read RFC 5334.

-Ivo

Hi !

Le Monday 22 September 2008 18:32:57 Ivo Emanuel Gon?alves, vous avez
?crit?:
> It seems like a fine patch, but you need to revise it because
> video/ogg and audio/ogg are registered media types for Ogg streams
> too. ?This, of course, is something recent, so don't blame yourself if
> you haven't heard.
Thanks for the review !

I don't get where the patch should be changed ? The default mime value for
ogg
streams ?


Romain