Hi, ices does not work very reliable here in my place. I am using the latest CVS sources and I get up to three times a day something like that: Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 2051 (LWP 8160)] 0x08051103 in resample_clear (s=0x40ef9338) at audio.c:142 142 if (s->buffers[c]) (gdb) bt #0 0x08051103 in resample_clear (s=0x40ef9338) at audio.c:142 #1 0x080504a3 in process_and_send_buffer (sdsc=0x805e448, buffer=0x8156238) at stream_shared.c:149 #2 0x0804d6ca in ices_instance_stream (arg=0x805e448) at stream.c:254 #3 0x080542b9 in _start_routine (arg=0x805e498) at thread.c:655 #4 0x402fa020 in pthread_start_thread () from /lib/i686/libpthread.so.0 btw: The way calling free in resample_clear does not look reasonable to me: if(s->buffers) { for(c=0; c<s->channels; c++) if (s->buffers[c]) free(s->buffers[c]); free(s->buffers); } I think the last free(s->buffers) is too much or am I too stupid? Deti <p>--- >8 ---- List archives: http://www.xiph.org/archives/ icecast project homepage: http://www.icecast.org/ To unsubscribe from this list, send a message to 'icecast-dev-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.
On Fri, 2003-08-01 at 23:24, Deti Fliegl wrote:> Hi, > > ices does not work very reliable here in my place. I am using the latest > CVS sources and I get up to three times a day something like that: > > Program received signal SIGSEGV, Segmentation fault. > [Switching to Thread 2051 (LWP 8160)] > 0x08051103 in resample_clear (s=0x40ef9338) at audio.c:142 > 142 if (s->buffers[c])<p>> btw: The way calling free in resample_clear does not look reasonable to me:> > if(s->buffers) { > for(c=0; c<s->channels; c++) > if (s->buffers[c]) > free(s->buffers[c]); > free(s->buffers); > } > > I think the last free(s->buffers) is too much or am I too stupid?that isn't the problem, we do need to free that. The problem is quite silly, as it's in the code actually identified. I've just committed a fix. karl. <p>--- >8 ---- List archives: http://www.xiph.org/archives/ icecast project homepage: http://www.icecast.org/ To unsubscribe from this list, send a message to 'icecast-dev-request@xiph.org' containing only the word 'unsubscribe' in the body. No subject is needed. Unsubscribe messages sent to the list will be ignored/filtered.