Xabier Oneca -- xOneca
2012-Dec-04 15:55 UTC
[Icecast] access.log: double quotes not escaped
Hello! I have seen that if an User Agent has double quotes in it will not be escaped when printed to access.log:> 192.168.0.2 - - [03/Dec/2012:20:45:54 +0100] "GET /stu HTTP/1.0" 200 313978 "-" "Che"atin" 15I saw the code and there is not code to address this. -- xOneca_,,_
Hi, thanks for your finding. On 04/12/12 17:55, Xabier Oneca -- xOneca wrote:> I have seen that if an User Agent has double quotes in it will not be > escaped when printed to access.log: > >> 192.168.0.2 - - [03/Dec/2012:20:45:54 +0100] "GET /stu HTTP/1.0" 200 313978 "-" "Che"atin" 15 > I saw the code and there is not code to address this.I have created a ticket to keep track of this issue: https://trac.xiph.org/ticket/1916 Cheers Thomas
reflum, On Sun, 2012-12-09 at 19:10 +0200, R?cker Thomas wrote:> On 04/12/12 17:55, Xabier Oneca -- xOneca wrote: > > I have seen that if an User Agent has double quotes in it will not be > > escaped when printed to access.log: > > > >> 192.168.0.2 - - [03/Dec/2012:20:45:54 +0100] "GET /stu HTTP/1.0" 200 313978 "-" "Che"atin" 15 > > I saw the code and there is not code to address this.Thanks for your report.> I have created a ticket to keep track of this issue: > https://trac.xiph.org/ticket/1916This should be fixed (a few days ago) in trunk. Please test. The ticket status is not yet updated as trac seems to have missed my commit. -- Philipp. (Rah of PH2) -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 482 bytes Desc: This is a digitally signed message part Url : http://lists.xiph.org/pipermail/icecast/attachments/20130105/26c167ba/attachment.pgp