ogg dev - Dec 2008 - [PATCH] liboggz: add dirac.c as a source, not as a lib

Hi,

this patch adds dirac.c as a source file to the oggz tools,
rather than a lib. The previous would try to compile at link
time, and would not include the right -I flags, and this will
fail when including config.h in dirac.c (which will be needed
when someone else posts a patch to get liboggz to build
on win32).
I'm not toally sure why dirac.c isn't just in the sources in
liboggz rather than in tools. Because of some visibility
issues, I suppose ? This patch doesn't make that better,
it just kind of sidesteps the issue, though.
Unless someone has a better fix ?

Thanks
-------------- next part --------------
A non-text attachment was scrubbed...
Name: liboggz-dirac.diff
Type: application/octet-stream
Size: 1883 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/ogg-dev/attachments/20081218/64a13f78/attachment.obj

thanks, applied in changeset:3834

Yes it would be good to do something nicer with dirac.c. Currently
that file is being copied around in a few projects, much like
skeleton.c.

Conrad.

2008/12/19 ogg.k.ogg.k at googlemail.com <ogg.k.ogg.k at
googlemail.com>:
> Hi,
>
> this patch adds dirac.c as a source file to the oggz tools,
> rather than a lib. The previous would try to compile at link
> time, and would not include the right -I flags, and this will
> fail when including config.h in dirac.c (which will be needed
> when someone else posts a patch to get liboggz to build
> on win32).
> I'm not toally sure why dirac.c isn't just in the sources in
> liboggz rather than in tools. Because of some visibility
> issues, I suppose ? This patch doesn't make that better,
> it just kind of sidesteps the issue, though.
> Unless someone has a better fix ?
>
> Thanks
>
> _______________________________________________
> ogg-dev mailing list
> ogg-dev at xiph.org
> http://lists.xiph.org/mailman/listinfo/ogg-dev
>
>