Ralph Giles
2008-Nov-17 22:56 UTC
[ogg-dev] [xiph-commits] r3789 - liboggz/trunk/src/tools/oggz-chop
On Mon, Nov 17, 2008 at 1:34 PM, <conrad at svn.annodex.net> wrote:> if (!strncmp ("t", key, 2)) { > - if ((sep = strchr (val, '/')) != NULL) { > + if (val && (sep = strchr (val, '/')) != NULL) { > *sep++ = '\0'; > state->end = parse_timespec (sep); > }Is is ok here for set_param to set the start time but not the end time? I guess it's initialized to -1.0 in cgi_main? -r
Conrad Parker
2008-Nov-17 23:37 UTC
[ogg-dev] [xiph-commits] r3789 - liboggz/trunk/src/tools/oggz-chop
2008/11/18 Ralph Giles <giles at xiph.org>:> On Mon, Nov 17, 2008 at 1:34 PM, <conrad at svn.annodex.net> wrote: > >> if (!strncmp ("t", key, 2)) { >> - if ((sep = strchr (val, '/')) != NULL) { >> + if (val && (sep = strchr (val, '/')) != NULL) { >> *sep++ = '\0'; >> state->end = parse_timespec (sep); >> } > > Is is ok here for set_param to set the start time but not the end > time? I guess it's initialized to -1.0 in cgi_main?it is already initialized to -1.0 (which is oggz-chop's internal representation for no end time), but it's more correct to explicitly set it there as you suggest. Fixed in changeset:3794. Conrad.