Steve
2017-May-02 22:38 UTC
[flac-dev] libFLAC with Android NDK: use of undeclared identifier 'SIZE_MAX'
Hi flac-dev, When we try to build libFLAC v1.3.1 using the Android NDK, we currently are getting an error in a couple files: ../../third_party/flac/src/libFLAC/md5.c:498:25: error: use of undeclared> identifier 'SIZE_MAX' > if ((size_t)channels > SIZE_MAX / (size_t)bytes_per_sample) >I filed a bug for it on the sourceforge bug tracker: https://sourceforge.net/p/flac/bugs/457/ This is fixed (in all NDK versions) by including limits.h. I've attached a simple patch that fixes the Android NDK build. Please let me know if theres any other process involved in getting this patch upstreamed. Thanks, ~Steve -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.xiph.org/pipermail/flac-dev/attachments/20170502/b51b21d2/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: flac_android.diff Type: application/octet-stream Size: 605 bytes Desc: not available URL: <http://lists.xiph.org/pipermail/flac-dev/attachments/20170502/b51b21d2/attachment.obj>
Erik de Castro Lopo
2017-May-03 09:29 UTC
[flac-dev] libFLAC with Android NDK: use of undeclared identifier 'SIZE_MAX'
Steve wrote:> Please let me know if theres any other process involved in getting this > patch upstreamed.A slightly modified version of your patch is in git HEAD: https://git.xiph.org/flac.git Please test and report back. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Reasonably Related Threads
- [LLVMdev] Clang now included in Android NDK r8c
- [LLVMdev] Clang now included in Android NDK r8c
- [LLVMdev] llvm shipping with android ndk for building ghc cross compiler
- [LLVMdev] Clang now included in Android NDK r8c
- [LLVMdev] Clang now included in Android NDK r8c