Hi all, I've been notified of a CVE to be publish against FLAC early next week. I have a patch for it and have thoroughly tested it as well as had it verified by the Google Security Team member who found it. I've been asked not to publish that patch until Tuesday. Once I publis the patch, I like to release FLAC 1.3.1 immediately and would therefore like to make sure that all the different platforms build correctly. I can test the following: i386-linux amd64-linux powerpc-linux amd64-freebsd amd64-openbsd and would appreciate it if people could test the other build systems and report back. The patch to fix the CVE is a trvial one-liner that will not affect the build systems whatsoever. Cheers, Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
On 11/22/14 07:14 PM, Erik de Castro Lopo wrote:> Once I publis the patch, I like to release FLAC 1.3.1 immediately and > would therefore like to make sure that all the different platforms > build correctly.Git head builds fine on OS/2 Dave
Erik de Castro Lopo wrote:> Once I publis the patch, I like to release FLAC 1.3.1 immediately and > would therefore like to make sure that all the different platforms > build correctly. I can test the following:I have a couple of questions: 1) Do you plan to release 1.3.1 pre1, pre2 etc or just 1.3.1 w/o any pre-releases? 2) Do you plan to release any official binaries (flac, metaflac, maybe something else)?
I tested MSYS + MinGW-w64 with GCC 4.9.2 and both 32-bit and 64-bit versions build without issues. MSVC 2013 Community version builds 32-bit and 64-bit release and debug versions without trouble. I don't have older Visual Studios installed but can make a virtual machine to test if lvqcl or someone else doesn't have any either. I have one related suggestion. The Windows solution files should be renamed. Right now the old solution file that one is supposed to use on old MSVC versions is called FLAC.sln and the new one is called FLAC-vs2010.sln. I'd like the main file FLAC.sln to be the one that works with all the latest Visual Studios and the old legacy format one be called FLAC-vs2005.sln.
lvqcl wrote:> I have a couple of questions: > > 1) Do you plan to release 1.3.1 pre1, pre2 etc or just 1.3.1 w/o any pre-releases?I had not planned to do a pre-release.> 2) Do you plan to release any official binaries (flac, metaflac, maybe something else)?Nor had I planned to release binaries. The source code tarball ends up here: https://svn.xiph.org/releases/flac/ I not sure where people normally get binaries (other than Linux users downloading it via their distribution). Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Janne Hyv?rinen wrote:> I have one related suggestion. The Windows solution files should be > renamed. Right now the old solution file that one is supposed to use on > old MSVC versions is called FLAC.sln and the new one is called > FLAC-vs2010.sln. I'd like the main file FLAC.sln to be the one that > works with all the latest Visual Studios and the old legacy format one > be called FLAC-vs2005.sln.Is that just a matter of renaming them as follows? mv FLAC.sln FLAC-vs2005.sln mv FLAC-vs2010.sln FLAC.sln Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
Janne Hyv?rinen wrote:> I tested MSYS + MinGW-w64 with GCC 4.9.2 and both 32-bit and 64-bit > versions build without issues. > MSVC 2013 Community version builds 32-bit and 64-bit release and debug > versions without trouble. I don't have older Visual Studios installed > but can make a virtual machine to test if lvqcl or someone else doesn't > have any either.MSVS Express 2005: ok for 32-bit; 64-bit build is not supported. MSVS Prof 2010 SP1: ok for 32-bit and 64-bit builds. ICC 2013 SP1: ok for 32-bit and 64-bit builds.> I have one related suggestion. The Windows solution files should be > renamed. Right now the old solution file that one is supposed to use on > old MSVC versions is called FLAC.sln and the new one is called > FLAC-vs2010.sln. I'd like the main file FLAC.sln to be the one that > works with all the latest Visual Studios and the old legacy format one > be called FLAC-vs2005.sln.+1. At least the old solution should be renamed from FLAC.sln to FLAC-vs2005.sln. Otherwise those who use MSVS 2012/2013 may think that they should use FLAC.sln instead of the newer FLAC-vs2010.sln. (the old solution is for MSVS 2005 and 2008, the new solution is for MSVS 2010 and newer: 2012, 2013, ...)
I can confirm git head builds and passes /make fullcheck/ (skipping the noise part of test_streams.sh) on - armv6-linux (Raspbian), GCC 4.6 & GCC 4.8 - i686-pc-mingw32, GCC 4.8.1 - MSVC 2005 Express 32-bit (make fullcheck with MinGW) - MSVC 2013 Express 32-bit (make fullcheck with MinGW) Furthermore, I've also ran the test_streams.sh of FLAC 1.2.1 with FLAC 1.2.1 as encoder and git as decoder and vice-versa, on amd64-linux, to make sure files encoded with git are still decodable in older versions etc. Considering Windows binaries: in case no new binaries are provided, please at least remove the old ones from sourceforge. As can be gleaned from some bug reports, support requests etc. on sourceforge, people are still happily downloading old versions. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://lists.xiph.org/pipermail/flac-dev/attachments/20141123/6d2826e7/attachment.htm