flac dev - Jan 2014 - PATCH: add FLAC__SSE_SUPPORTED and FLAC__SSE2_SUPPORTED

Currently the only way to compile FLAC using GCC w/o SSE support
is to disable asm optimizations (see configure.ac):

	if test "x$asm_optimisation" = "xyes" ; then
		XIPH_ADD_CFLAGS([-msse2])
		fi


Also it's not possible to enable SSE4.1 intrinsic functions even
with -msse4.1 option. The patch fixes both problems.


---------------
BTW: I'm not sure that share/compat.h is the best place to define these
FLAC__SSEN_SUPPORTED macros. Maybe it's better to move them to some libFLAC
.h file?
E.g. to src/libFLAC/include/private/cpu.h?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sse_support.patch
Type: application/octet-stream
Size: 10488 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/flac-dev/attachments/20140103/343e2b24/attachment.obj

Hi lvqcl,

Sorry to take so long to repond to this.

lvqcl wrote:
> Currently the only way to compile FLAC using GCC w/o SSE support
> is to disable asm optimizations (see configure.ac):
> 
> 	if test "x$asm_optimisation" = "xyes" ; then
> 		XIPH_ADD_CFLAGS([-msse2])
> 		fi
> 
> 
> Also it's not possible to enable SSE4.1 intrinsic functions even
> with -msse4.1 option. The patch fixes both problems.
> 
> 
> ---------------
> BTW: I'm not sure that share/compat.h is the best place to define these
> FLAC__SSEN_SUPPORTED macros. Maybe it's better to move them to some
libFLAC .h file?
> E.g. to src/libFLAC/include/private/cpu.h?
Yes, I think src/libFLAC/include/private/cpu.h would be a better place
for this SSE version support stuff.

Would you be able to do it or should I?

Cheers,
Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/

Erik de Castro Lopo wrote:
> Yes, I think src/libFLAC/include/private/cpu.h would be a better place
> for this SSE version support stuff.
>
> Would you be able to do it or should I?

OK, the attached patch adds FLAC__SSE*_SUPPORTED and also moves their
definitions to cpu.h.
It also adds GCC 4.9 support (http://gcc.gnu.org/gcc-4.9/changes.html:
"It is now possible to call x86 intrinsics from select functions in a file
that are tagged with the corresponding target attribute without having
to compile the entire file with the -mxxx option")

I also found that I wrote "#ifdef _MSC_VER" instead of
"#if defined _MSC_VER || defined __INTEL_COMPILER". The second
attached patch
fixes this.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 1_sse_support.patch
Type: application/octet-stream
Size: 17298 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/flac-dev/attachments/20140119/4ba3d1b7/attachment-0002.obj
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 2_ifdefs.patch
Type: application/octet-stream
Size: 2798 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/flac-dev/attachments/20140119/4ba3d1b7/attachment-0003.obj