The patch does the following: 1. splits lpc_x86intrin.c to lpc_intrin_sse.c and lpc_intrin_sse2.c 2. adds FLAC__lpc_compute_residual_from_qlp_coefficients_intrin_sse2() function to lpc_intrin_sse2.c 3. adds lpc_intrin_sse41.c with two ..._wide_intrin_sse41() functions (useful for 24-bit en-/decoding) 4. adds precompute_partition_info_sums_intrin_sse2() / ...ssse3() and disables precompute_partition_info_sums_32bit_asm_ia32_(). SSE2 version uses 4 SSE2 instructions instead of 1 SSSE3 instruction PABSD so it is slightly slower. MSVS 2005 doesn't support SSSE3 and SSE4, and GCC compiles everything with -msse2, so I wrapped SSSE3/SSE4.1 code with #ifdef FLAC__SSEx_SUPPORTED ... #endif. The code that defines FLAC__SSEx_SUPPORTED was added into share/compat.h (anyone knows a better way to do it?) -------------- next part -------------- A non-text attachment was scrubbed... Name: intrin_2.zip Type: application/zip Size: 14646 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20130928/634efd3a/attachment.zip
lvqcl wrote:> The patch does the following:Does the patch work for linux git? Windows git cannot apply a patch that was created itself. (It writes LF in diffs for .c/.cpp/.h/ files and CRLF in diffs for .sln/.vcproj files, and then rejects the patch because of CRLF sequences. It accept this patch after I replaced all CRLF -> LF).
lvqcl wrote:> lvqcl wrote: > > > The patch does the following: > > Does the patch work for linux git? Windows git cannot apply a patch > that was created itself.It looks like that patch was created with the 'git diff' command and hence cannot be applied using the 'git am' command. It does however apply using the patch command.> (It writes LF in diffs for .c/.cpp/.h/ files and CRLF in diffs for .sln/.vcproj files, > and then rejects the patch because of CRLF sequences. It accept this patch after I replaced > all CRLF -> LF).Have these patches that I apply look correct when you update your FLAC tree? Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
I modified the patch that adds ssse3/sse4.1 code: trailing whitespaces removed; code cleanup. New patch attached. -------------- next part -------------- A non-text attachment was scrubbed... Name: intrin_2a.zip Type: application/zip Size: 14547 bytes Desc: not available Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20131003/a7d83315/attachment.zip
Erik de Castro Lopo
2013-Oct-04 04:22 UTC
[flac-dev] PATCH UPDATE (modify/add intrinsics code)
lvqcl wrote:> I modified the patch that adds ssse3/sse4.1 code: > > trailing whitespaces removed; > code cleanup. > > New patch attached.Ooops, patch already applied and pushed when I saw this email. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/