Christian Weisgerber
2013-May-30 19:34 UTC
[flac-dev] 1.3.0: Symbol visibility breaks XMMS plugin
FLAC now defaults to building with -fvisibility=hidden on GCC4-ELF platforms. This breaks the XMMS plugin. At least get_iplugin_info() needs to be externally visible. --- src/plugin_xmms/plugin.c.orig Sun May 26 05:30:33 2013 +++ src/plugin_xmms/plugin.c Thu May 30 15:23:20 2013 @@ -140,7 +140,7 @@ static FLAC__bool is_big_endian_host_; static unsigned bitrate_history_[BITRATE_HIST_SIZE]; -InputPlugin *get_iplugin_info(void) +FLAC_API InputPlugin *get_iplugin_info(void) { flac_ip.description = g_strdup_printf("Reference FLAC Player v%s", FLAC__VERSION_STRING); return &flac_ip; -- Christian "naddy" Weisgerber naddy at mips.inka.de
Erik de Castro Lopo
2013-Jun-05 08:50 UTC
[flac-dev] 1.3.0: Symbol visibility breaks XMMS plugin
Christian Weisgerber wrote:> FLAC now defaults to building with -fvisibility=hidden on GCC4-ELF > platforms. This breaks the XMMS plugin. At least get_iplugin_info() > needs to be externally visible.Applied, thanks. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/