flac dev - Mar 2013 - [flac 1.3.0pre2 pre-release] Updates to test suite

Seems time is going to be a constraint for me in the coming week, but I'll
try and get more of these out to you as fast as I can get them written and
tested.  Keeping the patches in a separate branch for now seems like a good
idea to me.

Attached is a patch for 'test_streams.sh'


On Tue, Mar 12, 2013 at 1:44 AM, Erik de Castro Lopo
<mle+la at mega-nerd.com>wrote:
> Jaren Stangret wrote:
>
> > Attached are only three patches (each patch is for a different test
> > script).  If everyone is happy with these three patches, I'll
continue
> and
> > rework the rest of the scripts.
>
> These look good so far. I've commited them to a branch. When I
> get the rest I'll test them thoroughly as a batch.
>
> Erik
> --
> ----------------------------------------------------------------------
> Erik de Castro Lopo
> http://www.mega-nerd.com/
> _______________________________________________
> flac-dev mailing list
> flac-dev at xiph.org
> http://lists.xiph.org/mailman/listinfo/flac-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
http://lists.xiph.org/pipermail/flac-dev/attachments/20130312/74d38633/attachment-0001.htm
-------------- next part --------------
A non-text attachment was scrubbed...
Name: test_streams.sh.patch
Type: application/octet-stream
Size: 23689 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/flac-dev/attachments/20130312/74d38633/attachment-0001.obj

Attached is a patch for 'test_compression.sh'.

Interestingly, I noticed compression level '0' is omitted, so I've
added it
in.

Also, I tested this on a 24bit/96kHz FLAC file and the test failed between
compression level 0 and compression level 1 -- the file size was greater
with a compression level of 1, rather than 0.  The test works on
'noisy-sine.wav'.  It may be worth trying to run this test on a variety
of
FLAC files (multiple channels, multiple bps, multiple sample rates, etc).

What do you guys think?


On Tue, Mar 12, 2013 at 2:28 AM, Jaren Stangret <sirjaren at gmail.com>
wrote:
> Seems time is going to be a constraint for me in the coming week, but
I'll
> try and get more of these out to you as fast as I can get them written and
> tested.  Keeping the patches in a separate branch for now seems like a good
> idea to me.
>
> Attached is a patch for 'test_streams.sh'
>
>
> On Tue, Mar 12, 2013 at 1:44 AM, Erik de Castro Lopo <mle+la at
mega-nerd.com
> > wrote:
>
>> Jaren Stangret wrote:
>>
>> > Attached are only three patches (each patch is for a different
test
>> > script).  If everyone is happy with these three patches, I'll
continue
>> and
>> > rework the rest of the scripts.
>>
>> These look good so far. I've commited them to a branch. When I
>> get the rest I'll test them thoroughly as a batch.
>>
>> Erik
>> --
>> ----------------------------------------------------------------------
>> Erik de Castro Lopo
>> http://www.mega-nerd.com/
>> _______________________________________________
>> flac-dev mailing list
>> flac-dev at xiph.org
>> http://lists.xiph.org/mailman/listinfo/flac-dev
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
http://lists.xiph.org/pipermail/flac-dev/attachments/20130312/985ee068/attachment.htm
-------------- next part --------------
A non-text attachment was scrubbed...
Name: test_compression.sh.patch
Type: application/octet-stream
Size: 4526 bytes
Desc: not available
Url :
http://lists.xiph.org/pipermail/flac-dev/attachments/20130312/985ee068/attachment.obj

Jaren Stangret wrote:
> Interestingly, I noticed compression level '0' is omitted, so
I've added it
> in.
Thanks.
> Also, I tested this on a 24bit/96kHz FLAC file and the test failed between
> compression level 0 and compression level 1 -- the file size was greater
> with a compression level of 1, rather than 0.  The test works on
> 'noisy-sine.wav'.  It may be worth trying to run this test on a
variety of
> FLAC files (multiple channels, multiple bps, multiple sample rates, etc).
Compression levels are always highly dependent on the source material. This
particular test was added to test for the most gross kind of regressions
like the one I fixed in fc360735ce4d1aa88a94bfccdd3bea5bdd19a8d6.

When and if we come to update/improve FLAC's core compression code, that
is when we would need a more comprehensive test for compressed file sizes.

At this point, I think what we have is sufficient.

Cheers,
Erik
-- 
----------------------------------------------------------------------
Erik de Castro Lopo
http://www.mega-nerd.com/