On 11/10/2011 08:02, Erik de Castro Lopo wrote:> JonY wrote: > >> I submitted a patch sometime ago to correct printf specifiers for win32 >> by using inttypes.h, but there were no response, so I thought flac >> development was dead. > > Development is probably complete. Maintenance should continue. > >> Not sure where the patch went or if its still valid. > > If you sent it to this list, the mailing list archive should be here: > > http://lists.xiph.org/mailman/listinfo/flac-dev >Its probably on one of the sf tracker somewhere, I can't seem to find it anymore. It wasn't anything complicated, so I should be able to redo it quickly. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 196 bytes Desc: OpenPGP digital signature Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20111110/af4dd5b7/attachment.pgp
Erik de Castro Lopo
2011-Nov-10 10:39 UTC
[Flac-dev] Git branch with compiling fixes for win32
I'm subscribed to the list (and I set my reply-to to the list). Please do not CC me. JonY wrote:> Its probably on one of the sf tracker somewhere, I can't seem to find it > anymore. It wasn't anything complicated, so I should be able to redo it > quickly.I'm a Linux guy. I do not have easy access to a windows machine and don't have the time or patience to maintain one. For windows stuff I'll be relying on others to provide and test patches. Erik -- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/
On 11/10/2011 18:39, Erik de Castro Lopo wrote:> > I'm subscribed to the list (and I set my reply-to to the list). > Please do not CC me. > > JonY wrote: > >> Its probably on one of the sf tracker somewhere, I can't seem to find it >> anymore. It wasn't anything complicated, so I should be able to redo it >> quickly. > > I'm a Linux guy. I do not have easy access to a windows machine > and don't have the time or patience to maintain one. > > For windows stuff I'll be relying on others to provide and test > patches. > > ErikAlright, here's a quick fix, although it is more ugly than I remembered. Basically, it removes those _MSC_VER ifdefs, and relies on inttypes.h where available, and falls back to I64 on MSVC and then ll for others, all format warnings suppressed. Tested on MinGW. Sven-Hendrik, or any other mingw guys around, do you mind testing the patch too? Patch based on git master from https://git.xiph.org/mirrors/flac.git. -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: printf_quick_fix.txt Url: http://lists.xiph.org/pipermail/flac-dev/attachments/20111110/5507cb23/attachment-0001.txt -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 196 bytes Desc: OpenPGP digital signature Url : http://lists.xiph.org/pipermail/flac-dev/attachments/20111110/5507cb23/attachment-0001.pgp