Speex dev - Aug 2006 - bits.c problem

I'm trying to use speex on OMAP's DSP using dsp gateway, and have some
questions. The code almost works (within few next days I'll post a some kind
tutorial and patches), but it seems to be a little bug in bits.c. The code
looks like this

void speex_bits_read_from(SpeexBits *bits, char *chars, int len)

{

////////////////// bla-bla-bla /////////////////// 

  for (i=0;i<len;i++)

      bits->chars[i]=chars[i];

   bits->nbBits=len<<3;      //!!!!!!!!!!!!!!!!!!!

   bits->charPtr=0;

   bits->bitPtr=0;

   bits->overflow=0;

}

What is bits->nbBits=len<<3 ? Shouldn't it be
bits->nbBits=len<<3
LOG2_BITS_PER_CHAR ?

 

And another question. What is the difference between functions
speex_bits_read_from and speex_bits_read_whole_bytes ?

Thanks!

-------------- next part --------------
An HTML attachment was scrubbed...
URL:
http://lists.xiph.org/pipermail/speex-dev/attachments/20060802/cadc2ff2/attachment.html

Use the code from subversion.  The problem in bits.c was fixed in April, after
the 1.1.12 release.  There have been other fixes to TI operation, so you
definitely want to use the current code.  Jean-Marc has reduced the MIPs
substantially also.  The last build that I tested was 11717, released on 24
July.

Regards,

Jim Crichton
  ----- Original Message ----- 
  From: ??????? 
  To: speex-dev@xiph.org 
  Sent: Wednesday, August 02, 2006 2:48 AM
  Subject: [Speex-dev] bits.c problem


  I'm trying to use speex on OMAP's DSP using dsp gateway, and have some
questions. The code almost works (within few next days I'll post a some kind
tutorial and patches), but it seems to be a little bug in bits.c. The code looks
like this

  void speex_bits_read_from(SpeexBits *bits, char *chars, int len)

  {

  ////////////////// bla-bla-bla /////////////////// 

    for (i=0;i<len;i++)

        bits->chars[i]=chars[i];

     bits->nbBits=len<<3;      //!!!!!!!!!!!!!!!!!!!

     bits->charPtr=0;

     bits->bitPtr=0;

     bits->overflow=0;

  }

  What is bits->nbBits=len<<3 ? Shouldn't it be
bits->nbBits=len<<3 LOG2_BITS_PER_CHAR ?

   

  And another question. What is the difference between functions
speex_bits_read_from and speex_bits_read_whole_bytes ?

  Thanks!



------------------------------------------------------------------------------


  _______________________________________________
  Speex-dev mailing list
  Speex-dev@xiph.org
  http://lists.xiph.org/mailman/listinfo/speex-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
http://lists.xiph.org/pipermail/speex-dev/attachments/20060802/e0667e55/attachment.htm

Le mercredi 02 ao?t 2006 ? 09:48 +0300, ??????? a ?crit
:
> I?m trying to use speex on OMAP?s DSP using dsp gateway, and have some
> questions. The code almost works (within few next days I?ll post a
> some kind tutorial and patches), but it seems to be a little bug in
> bits.c. The code looks like this
That one was actually fixed in svn.
> And another question. What is the difference between functions
> speex_bits_read_from and speex_bits_read_whole_bytes ?
You most likely want to use speex_bits_read_from(). The only time you'd
want speex_bits_read_whole_bytes() is when concatenating Speex packets
in an endless stream. 

	Jean-Marc