Speex dev - Feb 2005 - a possible bug in 1.1.6

Hello Speex,

I think I've noticed a bug in version 1.1.6.

In the source file "speexdec.c", lines 558 to 560 say

   wav_format = strlen(outFile)>=4 && (
                                      
strcmp(outFile+strlen(outFile)-4,".wav")==0
                                       ||
strcmp(inFile+strlen(inFile)-4,".WAV")==0);

.  I think each "inFile" should be "outFile".  On the other
hand, if we really want to look at the "inFile", then we should check
its length also.


If there's another way I should report this, I'd be glad to hear.  Hope
this helps.

Regards,
Walt Mendenhall
(US) 303 960 5841
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
http://lists.xiph.org/pipermail/speex-dev/attachments/20050217/bfe53e27/attachment.html

Oops, there was indeed a bug. It's fixed in svn now.

	Jean-Marc

Le jeudi 17 f?vrier 2005 ? 17:23 -0700, Walt Mendenhall a ?crit
:
> Hello Speex,
>  
> I think I've noticed a bug in version 1.1.6.
>  
> In the source file "speexdec.c", lines 558 to 560 say
>  
>    wav_format = strlen(outFile)>=4 && (
>                                        strcmp(outFile
> +strlen(outFile)-4,".wav")==0
>                                        || strcmp(inFile
> +strlen(inFile)-4,".WAV")==0);
>  
> .  I think each "inFile" should be "outFile".  On the
other hand, if
> we really want to look at the "inFile", then we should check its
> length also.
>  
>  
> If there's another way I should report this, I'd be glad to hear.
> Hope this helps.
>  
> Regards,
> Walt Mendenhall
> (US) 303 960 5841
> _______________________________________________
> Speex-dev mailing list
> Speex-dev@xiph.org
> http://lists.xiph.org/mailman/listinfo/speex-dev
-- 
Jean-Marc Valin <Jean-Marc.Valin@USherbrooke.ca>
Universit? de Sherbrooke