samba - May 2020 - vfs_audit with Samba 4.12.3

Hello All,
now that the  BUG 14343: (s3: vfs_full_audit: Add missing fcntl entry in
vfs_op_names[] array.) was fixed I wanted to try 4.12 again.

This is the relevant config which has been running for years:

vfs objects = acl_xattr full_audit shadow_copy2
full_audit:failure = none
full_audit:success = pwrite write rename unlink
full_audit:prefix = IP=%I|USER=%u|MACHINE=%m|VOLUME=%S
full_audit:facility = local7
full_audit:priority = NOTICE

But with this an Samba 4.12.3 we get this error:


"Could not find opname rename, logging all"

This also happens for unlink.

What works is "renameat" and "unlinkat"

The man page still has it the old way:

The following Samba VFS operations are recorded:
           connect
           disconnect
           opendir
           mkdir
           rmdir
           open
           close
           rename
           unlink
           chmod
           fchmod



Is it a Bug in the documentation or the module or a new Feature :-)?

Regards

Christian

-- 
Dr. Christian Naumer
Unit Head Bioprocess Development

B.R.A.I.N Aktiengesellschaft
Darmstaedter Str. 34-36, D-64673 Zwingenberg
e-mail cn at brain-biotech.com, homepage www.brain-biotech.com
fon +49-6251-9331-30  /   fax +49-6251-9331-11

Sitz der Gesellschaft: Zwingenberg/Bergstrasse
Registergericht AG Darmstadt, HRB 24758
Vorstand: Adriaan Moelker (Vorstandsvorsitzender), 
Manfred Bender, Ludger Roedder
Aufsichtsratsvorsitzender: Dr. Georg Kellinghusen

On Tue, 2020-05-26 at 07:34 +0200, Christian Naumer via samba
wrote:
> Hello All,
> now that the  BUG 14343: (s3: vfs_full_audit: Add missing fcntl entry in
> vfs_op_names[] array.) was fixed I wanted to try 4.12 again.
> 
> This is the relevant config which has been running for years:
> 
> vfs objects = acl_xattr full_audit shadow_copy2
> full_audit:failure = none
> full_audit:success = pwrite write rename unlink
> full_audit:prefix = IP=%I|USER=%u|MACHINE=%m|VOLUME=%S
> full_audit:facility = local7
> full_audit:priority = NOTICE
> 
> But with this an Samba 4.12.3 we get this error:
> 
> 
> "Could not find opname rename, logging all"
> 
> This also happens for unlink.
> 
> What works is "renameat" and "unlinkat"
> 
> The man page still has it the old way:
Thanks.  This is https://bugzilla.samba.org/show_bug.cgi?id=14386

Sorry for the inconvenience and thanks for letting us know.

Andrew Bartlett
-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba