Sam Roberts
2005-Jan-01 23:25 UTC
[Vpim-talk] Re: vpim: bug in icalendar.rb, Icalendar#decode_status
Thanks for the bug report!
I''ll get a new release out next week, I''ve been on vacation
for a few
weeks and I''m just getting up to speed with being back in a city.
In the meantime, the fix is to apply the following patch (in
Icalendar.decode_duration). I''ve also integrated your tests, thanks.
Cheers,
Sam
diff -u -r1.22 icalendar.rb
--- vpim/icalendar.rb 17 Nov 2004 05:06:27 -0000 1.22
+++ vpim/icalendar.rb 2 Jan 2005 04:19:28 -0000
@@ -303,6 +303,8 @@
if match[1] && match[1] == ''-''
dur = -dur
end
+
+ dur
end
# Decode iCalendar data into an array of Icalendar objects.
Quoteing mmhohman@northwestern.edu, on Fri, Dec 10, 2004 at 11:49:30PM
-0600:> Hi,
>
> I''m running Ruby 1.8.2 preview 3 on OS X. At the end of
> Icalendar#decode_status, you don''t return dur if the duration
isn''t
> negative, i.e.
>
> if match[1] && match[1] == ''-''
> dur = -dur
> end
>
> is nil if the condition is false. I''ve attached some unit tests
showing
> that positive durations aren''t decoded correctly. Hope this helps.
>
> have a good weekend,
>
> Moses
>
Sam Roberts
2005-Jan-17 09:04 UTC
[Vpim-talk] Release 0.12 - now REALLY includes the vCard maker
Available from; http://vpim.rubyforge.org/ I forgot the vCard maker in the last release... oops. Heres''s the changelog: 0.12 - 2005-01-17 - removed require of pp from the library and utilities where it wasn''t needed, it was causing problems because it doesn''t exist on ruby 1.6 systems - Added Field#to_date, returns field value as an array of Date objects - Changed Field#to_time - it now auto-detects format of values (DATE/DATE-TIME). and doesn''t take/require a default_kind argument. - Added IMPP support to Vpim::Maker::Vcard. - Makefile wasn''t copying the Maker classes into the release. - Duration value not returned unless it was negative, fixed. - An RRULE''s UNTIL was always being assumed to be a DATE-TIME, but it can be a DATE. I fixed this, but is something of a hack, see comments and TODO. - Use String#scan instead of String#gsub, when appropriate (I didn''t know it existed when I stated the project). - Run tests on 3 ruby versions. - Don''t include docs in release package, it makes it way too large. - Change: use String.unpack instead of iconv to convert UCS-2 to UTF-8, removing dependency on iconv (it wasn''t standard in ruby 1.6). - Change: simplified mutt_ab_query.rb, and renamed to vcf-to-mutt. - Change: reminder.rb sorts todo items by priority. - New: Vtodo#priority - the priority of the vTodo component. Cheers, Sam