Jeff, I don''t quite understand all of Florian''s new code in event.rb. It broke the TcpServerEventableIO class (in eio.rb) which of course calls super in its constructor. What will this new code do if someone really needs to call super? -------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/eventmachine-talk/attachments/20060531/8c7a5df8/attachment.htm
It should still work fine if someone calls super, but I don''t think I like it either. I pulled it out last night, and once I get this example of what I emailed last night running I''ll check it in so you can take a look. Francis Cianfrocca wrote:> Jeff, I don''t quite understand all of Florian''s new code in event.rb. It > broke the TcpServerEventableIO class (in eio.rb) which of course calls > super in its constructor. What will this new code do if someone really > needs to call super? > > > ------------------------------------------------------------------------ > > _______________________________________________ > Eventmachine-talk mailing list > Eventmachine-talk at rubyforge.org > http://rubyforge.org/mailman/listinfo/eventmachine-talk
Ok thx, I''ll wait for you. On 5/31/06, Jeff Rose <jeff at rosejn.net> wrote:> > It should still work fine if someone calls super, but I don''t think I > like it either. I pulled it out last night, and once I get this example > of what I emailed last night running I''ll check it in so you can take a > look. > > Francis Cianfrocca wrote: > > Jeff, I don''t quite understand all of Florian''s new code in event.rb. It > > broke the TcpServerEventableIO class (in eio.rb) which of course calls > > super in its constructor. What will this new code do if someone really > > needs to call super? > > > > > > ------------------------------------------------------------------------ > > > > _______________________________________________ > > Eventmachine-talk mailing list > > Eventmachine-talk at rubyforge.org > > http://rubyforge.org/mailman/listinfo/eventmachine-talk > > _______________________________________________ > Eventmachine-talk mailing list > Eventmachine-talk at rubyforge.org > http://rubyforge.org/mailman/listinfo/eventmachine-talk >-------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/eventmachine-talk/attachments/20060531/f5446f63/attachment.htm
I just added a test called net_test.rb which fails in the presence of Florian''s code. On 5/31/06, Jeff Rose <jeff at rosejn.net> wrote:> > It should still work fine if someone calls super, but I don''t think I > like it either. I pulled it out last night, and once I get this example > of what I emailed last night running I''ll check it in so you can take a > look. > > Francis Cianfrocca wrote: > > Jeff, I don''t quite understand all of Florian''s new code in event.rb. It > > broke the TcpServerEventableIO class (in eio.rb) which of course calls > > super in its constructor. What will this new code do if someone really > > needs to call super? > > > > > > ------------------------------------------------------------------------ > > > > _______________________________________________ > > Eventmachine-talk mailing list > > Eventmachine-talk at rubyforge.org > > http://rubyforge.org/mailman/listinfo/eventmachine-talk > > _______________________________________________ > Eventmachine-talk mailing list > Eventmachine-talk at rubyforge.org > http://rubyforge.org/mailman/listinfo/eventmachine-talk >-------------- next part -------------- An HTML attachment was scrubbed... URL: http://rubyforge.org/pipermail/eventmachine-talk/attachments/20060531/5449fa2c/attachment.htm