Hi All, Yesterday Fabien sent me a bunch of enhancements, which I''ve attached to this message. I wanted to respond on the list, so others could voice their opinions. Fabien-- I''ve looked over your patch, and I''m quite impressed-- it looks like you have done excellent work on better_nested_set. My specific comments are as follows: The new find and count methods look great, and ought to be quite useful (e.g. trac ticket 18). The methods #recurse_result_set, #result_to_array and #result_to_xml all look fine to me, though I''m not the person to ask. JCM-- do you have input on these methods, based on your work with the helper? I like the new sibling query methods (#next_sibling and friends), but I''m wondering if we should use the same method names as acts_as_list, to maintain interchangeability. Should #move_to_top and #move_to_bottom use #swap? It seems that this will cause unexpected reordering. If we had nodes (a, b, c, d) and we called a.move_to_bottom, the order would be (d, b, c, a) instead of the expected (for me at least) (b, c, d, a). Which brings us to the #swap method itself-- all of the new sibling reordering methods could be accomplished with existing move_to methods, so I''m wondering how much of a need for #swap there is. (I recognize that #swap offers performance benefits if you do need to swap two distant nodes.) If we decide to keep it, I think the update statements for #swap and #move_to are equivalent, and could be handled by a single method. That''s it for my comments-- what does everyone else on the list think? I really like these enhancements, and I am looking forward to seeing them committed. Krishna -------------- next part -------------- A non-text attachment was scrubbed... Name: betternestedset.zip Type: application/zip Size: 28196 bytes Desc: not available Url : http://rubyforge.org/pipermail/betternestedset-talk/attachments/20070109/20217abb/attachment-0001.zip