Xapian devel - Oct 2017 - Current master unit test errors

I'm preparing a pull request for the master branch and noticed that
`make check` on a clone of the xapian repository fails badly. I haven't
merged my changes and built from e24cc6018de0. Is is just me or is there
something broken in the master branch?

    Running test './apitest' under valgrind
    Running tests with backend "none"...
    Running test: defaultctor1... SIGSEGV at (nil)
    DecreasingValueWeightPostingSource()
    [...]
    Running test: uninitdb1... InvalidArgumentError: Can't make an
    Enquire object from an uninitialised Database object.
    Running test: rset4... FAILED
    Running test: valuesetmatchdecider1... FAILED
    Running test: emptymset1... InvalidOperationError: Can't get
    termfreq from an MSet which is not derived from a query.
    Running test: nonutf8docdesc1... FAILED
    Running test: orphaneddoctermitor1... Invalid read of size 8
    Running test: serialise_query2... SIGSEGV at (nil)
    Running test: serialise_query3... SIGSEGV at (nil)
   ./apitest backend none: 134 tests passed, 9 failed.

Cheers,
Robert

On Mon, Oct 16, 2017 at 01:39:55PM +0200, Robert Stepanek
wrote:
> I'm preparing a pull request for the master branch and noticed that
> `make check` on a clone of the xapian repository fails badly. I haven't
> merged my changes and built from e24cc6018de0. Is is just me or is there
> something broken in the master branch?
I think it's just you...

While there has been the odd moment of breakage on master in recent weeks
(mostly due to failure that only happen with assertions on or off and similar),
that particular version works for me and works for travis:

https://travis-ci.org/xapian/xapian/builds/288405571

Buildbot's unhappy, but that's down to infrastructure issues with the
VM it runs on - it's not even getting to build code right now.

This is highly suspect:
>     Running test: uninitdb1... InvalidArgumentError: Can't make an
>     Enquire object from an uninitialised Database object.
That error message isn't present in e24cc6018de0 as it was removed in
d9c72787b18f51d4df6e151346280000a825338d, and that part of the testcase
changed to check that it works (it was a rather arbitrary historical
restriction that you couldn't do Enquire(Database()) and a default
constructed database works as a database with no documents in general).

So it looks to me like you're running tests using libxapian from a previous
build somehow (and that could also explain the failure you were trying to
fix in https://github.com/xapian/xapian/pull/139 which neither I nor the
CI builds could reproduce).

Perhaps you are setting LD_LIBRARY_PATH in your .bashrc or similar?

Cheers,
    Olly

On Mon, Oct 16, 2017, at 20:43, Olly Betts wrote:
> So it looks to me like you're running tests using libxapian from a
> previous build somehow
Many thanks for the sleuthing, Olly! That was indeed the issue and my PR
now cleanly passed local unit tests.

I just submitted https://github.com/xapian/xapian/pull/180

Cheers,
Robert