On Fri, Sep 25, 2020 at 05:03:24PM +0800, Wei Wang wrote:> On Fri, Sep 25, 2020 at 4:54 PM Daniel P. Berrangé <berrange@redhat.com> > wrote: > > > > > > Yes, I tried, but it fails with > > > ../src/util/virfile.c:42:11: fatal error: libutil.h: No such file or > > > directory > > > > You'd have to delete the build dir and re-run meson so that it > > auto-detects again. > > > > > OK, that issue seems gone, but ninja reports lots of new errors: > > > ninja: Entering directory `build' > [947/1250] Generating virsh.html.in with a meson_exe.py custom command > FAILED: docs/manpages/virsh.html.in > /usr/bin/meson --internal exe --capture docs/manpages/virsh.html.in -- > /usr/local/bin/rst2html5 --stylesheet= --strict docs/manpages/virsh.rst > docs/manpages/virsh.rst:41: (ERROR/3) Error in "code-block" directive: > 1 argument(s) required, 0 supplied. > > .. code-block:: > > virsh [OPTION]... <command> <domain> [ARG]...This is a sign of having a bad version of "rst2html5" installed. We expect to be using rst2html5 that comes with python docutils package. There is a completely different rst2html5 that people might get from "pip" if you did "pip install rst2html5". This version is broken and unusable and so needs to be removed. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
On Fri, 2020-09-25 at 10:16 +0100, Daniel P. Berrangé wrote:> On Fri, Sep 25, 2020 at 05:03:24PM +0800, Wei Wang wrote: > > /usr/local/bin/rst2html5 --stylesheet= --strict docs/manpages/virsh.rst > > docs/manpages/virsh.rst:41: (ERROR/3) Error in "code-block" directive: > > 1 argument(s) required, 0 supplied. > > > > .. code-block:: > > > > virsh [OPTION]... <command> <domain> [ARG]... > > This is a sign of having a bad version of "rst2html5" installed. > > We expect to be using rst2html5 that comes with python docutils > package.Yeah, the python3-docutils Debian package will contain a working rst2html5 binary.> There is a completely different rst2html5 that people might get > from "pip" if you did "pip install rst2html5". This version is > broken and unusable and so needs to be removed.Can we do something to get that package off PyPi? It's not the first time the overlap has caused trouble for our users, and it certainly won't be the last... -- Andrea Bolognani / Red Hat / Virtualization
On Fri, Sep 25, 2020 at 11:23:57AM +0200, Andrea Bolognani wrote:> On Fri, 2020-09-25 at 10:16 +0100, Daniel P. Berrangé wrote: > > On Fri, Sep 25, 2020 at 05:03:24PM +0800, Wei Wang wrote: > > > /usr/local/bin/rst2html5 --stylesheet= --strict docs/manpages/virsh.rst > > > docs/manpages/virsh.rst:41: (ERROR/3) Error in "code-block" directive: > > > 1 argument(s) required, 0 supplied. > > > > > > .. code-block:: > > > > > > virsh [OPTION]... <command> <domain> [ARG]... > > > > This is a sign of having a bad version of "rst2html5" installed. > > > > We expect to be using rst2html5 that comes with python docutils > > package. > > Yeah, the python3-docutils Debian package will contain a working > rst2html5 binary. > > > There is a completely different rst2html5 that people might get > > from "pip" if you did "pip install rst2html5". This version is > > broken and unusable and so needs to be removed. > > Can we do something to get that package off PyPi? It's not the first > time the overlap has caused trouble for our users, and it certainly > won't be the last...Well it is not really our place to demand its removal. It isn't violating any rules of PyPi and AFAICT, it existed before docutils provided the same binary name. The only good course of action is probably to submit a patch to actually make it work. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
On Fri, Sep 25, 2020 at 5:24 PM Andrea Bolognani <abologna@redhat.com> wrote:> On Fri, 2020-09-25 at 10:16 +0100, Daniel P. Berrangé wrote: > > On Fri, Sep 25, 2020 at 05:03:24PM +0800, Wei Wang wrote: > > > /usr/local/bin/rst2html5 --stylesheet= --strict docs/manpages/virsh.rst > > > docs/manpages/virsh.rst:41: (ERROR/3) Error in "code-block" directive: > > > 1 argument(s) required, 0 supplied. > > > > > > .. code-block:: > > > > > > virsh [OPTION]... <command> <domain> [ARG]... > > > > This is a sign of having a bad version of "rst2html5" installed. > > > > We expect to be using rst2html5 that comes with python docutils > > package. > > Yeah, the python3-docutils Debian package will contain a working > rst2html5 binary. > >That's strange, my rst2html5 comes from docutils: python3-docutils: /usr/share/docutils/scripts/python3/rst2html5 and /usr/local/bin/rst2html5 --version rst2html5 (Docutils 0.16 [release], Python 3.8.2, on linux) Thanks, Wei