Richard W.M. Jones
2017-Dec-10 21:17 UTC
[Libguestfs] [PATCH] configure: Don't define _FORTIFY_SOURCE.
We routinely test the upstream code by running everything under valgrind, and in any case _FORTIFY_SOURCE is usually defined by downstream Linux distros and we can leave the optimization vs safety decision to them. See this bug: https://bugs.gentoo.org/640494 --- m4/guestfs-c.m4 | 6 ------ 1 file changed, 6 deletions(-) diff --git a/m4/guestfs-c.m4 b/m4/guestfs-c.m4 index 932b6de73..3e8642675 100644 --- a/m4/guestfs-c.m4 +++ b/m4/guestfs-c.m4 @@ -119,12 +119,6 @@ AC_SUBST([NO_UM_CFLAGS]) AC_DEFINE([lint], [1], [Define to 1 if the compiler is checking for lint.]) AC_DEFINE([GNULIB_PORTCHECK], [1], [Enable some gnulib portability checks.]) -AH_VERBATIM([FORTIFY_SOURCE],[ -/* Enable compile-time and run-time bounds-checking, and some warnings. */ -#if __OPTIMIZE__ && (! defined (_FORTIFY_SOURCE) || _FORTIFY_SOURCE < 2) -# undef _FORTIFY_SOURCE -# define _FORTIFY_SOURCE 2 -#endif]) AC_C_PROTOTYPES test "x$U" != "x" && AC_MSG_ERROR([Compiler not ANSI compliant]) -- 2.13.2
Pino Toscano
2018-Jan-16 16:01 UTC
Re: [Libguestfs] [PATCH] configure: Don't define _FORTIFY_SOURCE.
On Sunday, 10 December 2017 22:17:28 CET Richard W.M. Jones wrote:> We routinely test the upstream code by running everything under > valgrind, and in any case _FORTIFY_SOURCE is usually defined by > downstream Linux distros and we can leave the optimization vs safety > decision to them. > > See this bug: https://bugs.gentoo.org/640494 > ---LGTM. -- Pino Toscano