Hilko Bengen
2017-Sep-05  21:24 UTC
[Libguestfs] [PATCH] run.in: Quote contents of @VAR@ substitutions
---
 run.in | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/run.in b/run.in
index 0d10983..0f23a7c 100755
--- a/run.in
+++ b/run.in
@@ -62,7 +62,7 @@ export PERL_VALGRIND=1
 export PERL_DESTRUCT_LEVEL=2
 
 # For Python.
-export PYTHON=@PYTHON@
+export PYTHON="@PYTHON@"
 if [ -z "$PYTHONPATH" ]; then
     PYTHONPATH="$s/python:$b/python:$b/python/.libs"
 else
@@ -71,8 +71,8 @@ fi
 export PYTHONPATH
 
 # For Ruby.
-export RUBY=@RUBY@
-export RAKE=@RAKE@
+export RUBY="@RUBY@"
+export RAKE="@RAKE@"
 if [ -z "$RUBYLIB" ]; then
     RUBYLIB="$s/ruby/lib:$b/ruby/ext/hivex"
 else
-- 
2.14.1
Richard W.M. Jones
2017-Sep-05  22:14 UTC
Re: [Libguestfs] [PATCH] run.in: Quote contents of @VAR@ substitutions
Hi Hilko, I believe this has already been applied upstream (commit eecb1d81777219113f7e5434829aca6f93a92b9a) so it's not necessary. Let me know if I've missed something. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines. Boot with a live CD or over the network (PXE) and turn machines into KVM guests. http://libguestfs.org/virt-v2v
Hilko Bengen
2017-Sep-06  11:07 UTC
Re: [Libguestfs] [PATCH] run.in: Quote contents of @VAR@ substitutions
* Richard W.M. Jones:> I believe this has already been applied upstream > (commit eecb1d81777219113f7e5434829aca6f93a92b9a) so it's not necessary.Sorry, I should have indicated that this patch was for hivex. The quotes are still missing there. Cheers, -Hilko
Possibly Parallel Threads
- [PATCH] run.in: Quote contents of @VAR@ substitutions
- Re: [PATCH] run.in: Quote contents of @VAR@ substitutions
- [PATCH] ./run: Use 'prepend' function to build paths.
- Re: [PATCH] run.in: Quote contents of @VAR@ substitutions
- [PATCH 1/3] ruby: Fix tests for out-of-tree build, simplify test scripts