Daniel Vetter
2019-Dec-13 17:26 UTC
[PATCH 08/10] drm/virtio: plane_state->fb iff plane_state->crtc
Checking both is one too much, so wrap a WARN_ON around it to stope the copypasta. Signed-off-by: Daniel Vetter <daniel.vetter at intel.com> Cc: David Airlie <airlied at linux.ie> Cc: Gerd Hoffmann <kraxel at redhat.com> Cc: virtualization at lists.linux-foundation.org --- drivers/gpu/drm/virtio/virtgpu_plane.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio/virtgpu_plane.c index bc4bc4475a8c..947e65b51555 100644 --- a/drivers/gpu/drm/virtio/virtgpu_plane.c +++ b/drivers/gpu/drm/virtio/virtgpu_plane.c @@ -88,7 +88,7 @@ static int virtio_gpu_plane_atomic_check(struct drm_plane *plane, struct drm_crtc_state *crtc_state; int ret; - if (!state->fb || !state->crtc) + if (!state->fb || WARN_ON(!state->crtc)) return 0; crtc_state = drm_atomic_get_crtc_state(state->state, state->crtc); -- 2.24.0
Reasonably Related Threads
- [PATCH] drm/virtio: add plane check
- [PATCH 5/5] drm/virtio: factor out virtio_gpu_update_dumb_bo
- [PATCH v2 3/3] drm/virtio: factor out virtio_gpu_update_dumb_bo
- [PATCH 3/3] drm/atomic: Make disable_all helper fully disable the crtc.
- [Intel-gfx] [PATCH 1/3] drm/atomic: Make disable_all helper fully disable the crtc.