Stefan Hajnoczi
2019-Nov-12 10:33 UTC
[PATCH v2] virtiofs: Use static const, not const static
On Mon, Nov 11, 2019 at 08:15:45PM +0800, zhengbin wrote:> Move the static keyword to the front of declarations, which resolves > compiler warnings when building with "W=1": > > fs/fuse/virtio_fs.c:687:1: warning: ?static? is not at beginning of declaration [-Wold-style-declaration] > const static struct virtio_device_id id_table[] = { > ^ > fs/fuse/virtio_fs.c:692:1: warning: ?static? is not at beginning of declaration [-Wold-style-declaration] > const static unsigned int feature_table[] = {}; > ^ > fs/fuse/virtio_fs.c:1029:1: warning: ?static? is not at beginning of declaration [-Wold-style-declaration] > const static struct fuse_iqueue_ops virtio_fs_fiq_ops = { > > Reported-by: Hulk Robot <hulkci at huawei.com> > Signed-off-by: zhengbin <zhengbin13 at huawei.com> > --- > v1->v2: modify comment > fs/fuse/virtio_fs.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-)Reviewed-by: Stefan Hajnoczi <stefanha at redhat.com> -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 488 bytes Desc: not available URL: <http://lists.linuxfoundation.org/pipermail/virtualization/attachments/20191112/68fcd72e/attachment-0001.sig>
Maybe Matching Threads
- [PATCH v2] virtiofs: Use static const, not const static
- [PATCH] virtiofs: Use static const, not const static
- [PATCH] virtiofs: Remove set but not used variable 'fc'
- [PATCH -next] virtiofs: Fix old-style declaration
- [PATCH 15/18] virtiofs: Make virtio_fs object refcounted