Nouveau - Jun 2020 - [PATCH] drm/nouveau/clk/gm20b: Fix memory leak in gm20b_clk_new()

The original patch was basically fine.  Just add a Fixes tag and resend.

regards,
dan carpenter

> The original patch was basically fine.
I propose to reconsider the interpretation of the software situation once more.

* Should the allocated clock object be kept usable even after
  a successful return from this function?

* How much do ?destructor? calls matter here for (sub)devices?

> Just add a Fixes tag and resend.
This tag can help also.

Regards,
Markus

On Tue, Jun 02, 2020 at 01:10:34PM +0200, Markus Elfring
wrote:
> > The original patch was basically fine.
> 
> I propose to reconsider the interpretation of the software situation once
more.
> 
> * Should the allocated clock object be kept usable even after
>   a successful return from this function?
Heh.  You're right.  The patch is freeing "clk" on the success
path so
that doesn't work.

regards,
dan carpenter