We are deprecating calls which return NULL in favor of new variants which return an ERR_PTR. Only build tested. Wolfram Sang (6): drm/amdgpu: convert to use i2c_new_client_device() drm/gma500: convert to use i2c_new_client_device() drm/i2c/sil164: convert to use i2c_new_client_device() drm/i2c/tda998x: convert to use i2c_new_client_device() drm/nouveau/therm: convert to use i2c_new_client_device() drm/radeon: convert to use i2c_new_client_device() drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.c | 2 +- drivers/gpu/drm/gma500/tc35876x-dsi-lvds.c | 8 ++++---- drivers/gpu/drm/i2c/sil164_drv.c | 7 +++++-- drivers/gpu/drm/i2c/tda998x_drv.c | 6 +++--- drivers/gpu/drm/nouveau/nvkm/subdev/therm/ic.c | 4 ++-- drivers/gpu/drm/radeon/radeon_atombios.c | 4 ++-- drivers/gpu/drm/radeon/radeon_combios.c | 4 ++-- 7 files changed, 19 insertions(+), 16 deletions(-) -- 2.20.1
Wolfram Sang
2020-Mar-26 21:10 UTC
[Nouveau] [PATCH 5/6] drm/nouveau/therm: convert to use i2c_new_client_device()
Move away from the deprecated API and return the shiny new ERRPTR where useful. Signed-off-by: Wolfram Sang <wsa+renesas at sang-engineering.com> --- drivers/gpu/drm/nouveau/nvkm/subdev/therm/ic.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/therm/ic.c b/drivers/gpu/drm/nouveau/nvkm/subdev/therm/ic.c index 03b355dabab3..abf3eda683f0 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/therm/ic.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/therm/ic.c @@ -36,8 +36,8 @@ probe_monitoring_device(struct nvkm_i2c_bus *bus, request_module("%s%s", I2C_MODULE_PREFIX, info->type); - client = i2c_new_device(&bus->i2c, info); - if (!client) + client = i2c_new_client_device(&bus->i2c, info); + if (IS_ERR(client)) return false; if (!client->dev.driver || -- 2.20.1
On Thu, Mar 26, 2020 at 10:09:58PM +0100, Wolfram Sang wrote:> We are deprecating calls which return NULL in favor of new variants which > return an ERR_PTR. Only build tested. > > > Wolfram Sang (6): > drm/amdgpu: convert to use i2c_new_client_device() > drm/gma500: convert to use i2c_new_client_device() > drm/i2c/sil164: convert to use i2c_new_client_device() > drm/i2c/tda998x: convert to use i2c_new_client_device() > drm/nouveau/therm: convert to use i2c_new_client_device() > drm/radeon: convert to use i2c_new_client_device()With the ack from Alex I went ahead and applied the patches to drm-misc-next. Sam> > drivers/gpu/drm/amd/amdgpu/amdgpu_dpm.c | 2 +- > drivers/gpu/drm/gma500/tc35876x-dsi-lvds.c | 8 ++++---- > drivers/gpu/drm/i2c/sil164_drv.c | 7 +++++-- > drivers/gpu/drm/i2c/tda998x_drv.c | 6 +++--- > drivers/gpu/drm/nouveau/nvkm/subdev/therm/ic.c | 4 ++-- > drivers/gpu/drm/radeon/radeon_atombios.c | 4 ++-- > drivers/gpu/drm/radeon/radeon_combios.c | 4 ++-- > 7 files changed, 19 insertions(+), 16 deletions(-) > > -- > 2.20.1 > > _______________________________________________ > dri-devel mailing list > dri-devel at lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
Possibly Parallel Threads
- [PATCH 0/6] gpu: convert to use new I2C API
- [PATCH 5/6] drm/nouveau/therm: convert to use i2c_new_client_device()
- [PATCH v2 01/12] drm/amdgpu, drm/radeon: Make I2C terminology more inclusive
- [PATCH v2 01/12] drm/amdgpu, drm/radeon: Make I2C terminology more inclusive
- [PATCH v2 01/12] drm/amdgpu, drm/radeon: Make I2C terminology more inclusive