Lyude Paul
2018-Dec-11 23:56 UTC
[Nouveau] [PATCH] drm/nouveau: Fix memory leak in nv50_mstm_del()
Noticed this while working on redoing the reference counting scheme in the DP MST helpers. Nouveau doesn't attempt to call drm_dp_mst_topology_mgr_destroy() at all, which leaves it leaking all of the resources for drm_dp_mst_topology_mgr and it's children mstbs+ports. Fixes: f479c0ba4a17 ("drm/nouveau/kms/nv50: initial support for DP 1.2 multi-stream") Signed-off-by: Lyude Paul <lyude at redhat.com> Cc: <stable at vger.kernel.org> # v4.10+ --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c index d153ea2a08ac..a634b3d0b6a1 100644 --- a/drivers/gpu/drm/nouveau/dispnv50/disp.c +++ b/drivers/gpu/drm/nouveau/dispnv50/disp.c @@ -1254,6 +1254,7 @@ nv50_mstm_del(struct nv50_mstm **pmstm) { struct nv50_mstm *mstm = *pmstm; if (mstm) { + drm_dp_mst_topology_mgr_destroy(&mstm->mgr); kfree(*pmstm); *pmstm = NULL; } -- 2.19.2
Sasha Levin
2018-Dec-12 05:46 UTC
[Nouveau] [PATCH] drm/nouveau: Fix memory leak in nv50_mstm_del()
Hi, [This is an automated email] This commit has been processed because it contains a "Fixes:" tag, fixing commit: f479c0ba4a17 drm/nouveau/kms/nv50: initial support for DP 1.2 multi-stream. The bot has tested the following trees: v4.19.8, v4.14.87, v4.19.8: Build OK! v4.14.87: Failed to apply! Possible dependencies: Unable to calculate How should we proceed with this patch? -- Thanks, Sasha
Lyude Paul
2018-Dec-12 17:40 UTC
[Nouveau] [PATCH] drm/nouveau: Fix memory leak in nv50_mstm_del()
v4.19.8, it's ok to skip v4.14 for this On Wed, 2018-12-12 at 05:46 +0000, Sasha Levin wrote:> Hi, > > [This is an automated email] > > This commit has been processed because it contains a "Fixes:" tag, > fixing commit: f479c0ba4a17 drm/nouveau/kms/nv50: initial support for DP 1.2 > multi-stream. > > The bot has tested the following trees: v4.19.8, v4.14.87, > > v4.19.8: Build OK! > v4.14.87: Failed to apply! Possible dependencies: > Unable to calculate > > > How should we proceed with this patch? > > -- > Thanks, > Sasha-- Cheers, Lyude Paul
Maybe Matching Threads
- [PATCH] drm/nouveau: Fix memory leak in nv50_mstm_del()
- [PATCH 2/4] drm/dp_mst: Pass entire connector to drm_dp_mst_topology_mgr_init()
- [PATCH v2 2/4] drm/dp_mst: Pass entire connector to drm_dp_mst_topology_mgr_init()
- [PATCH] drm/nouveau: Check rc from drm_dp_mst_topology_mgr_resume()
- [PATCH] drm/nouveau: Check rc from drm_dp_mst_topology_mgr_resume()