Nouveau - Mar 2017 - [Bug 100446] New: Backlight control not working on Pascal / GP106 using nouveau drivers

https://bugs.freedesktop.org/show_bug.cgi?id=100446

            Bug ID: 100446
           Summary: Backlight control not working on Pascal / GP106 using
                    nouveau drivers
           Product: xorg
           Version: unspecified
          Hardware: x86-64 (AMD64)
                OS: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Driver/nouveau
          Assignee: nouveau at lists.freedesktop.org
          Reporter: carlo at caione.org
        QA Contact: xorg-team at lists.x.org

I'm currently working on an ASUS GL702VMK. This machine is shipping a
GeForce
GTX 1060 GP106 (136000a1) connected to an internal DisplayPort on DFP-5 (usual
AU Optronics Corporation).

Using the unmodified latest nouveau drivers I have no backlight control.
Modifying nouveau_backlight.c adding a case for NV_DEVICE_INFO_V0_PASCAL I
finally get /sys/class/backlight/nv_backlight/ but changing the backlight value
in there is not working anyway.

Trying to manually poke NV50_PDISP_SOR_PWM_CTL(1) with `nvapoke` has no effect
whatsoever on the brightness (on or==1)

Backlight control is not working using the proprietary 375 / 378 drivers
either. Also in this case the value of NV50_PDISP_SOR_PWM_CTL is actually
changed by `xbacklight` but with no visible effect.

Any hint?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20170329/44be3aca/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=100446

--- Comment #1 from Carlo Caione <carlo at caione.org> ---
Created attachment 130784
  --> https://bugs.freedesktop.org/attachment.cgi?id=130784&action=edit
vbios + mmiotrace

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20170410/0af86480/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=100446

--- Comment #2 from Carlo Caione <carlo at caione.org> ---
In attachment (tar + xz -9):
- vbios
- mmiotrace
- demmio'd mmiotrace

The trace was taken in pure Xorg with only xterm running and:

echo "XSET50IN" > /sys/kernel/debug/tracing/trace_marker
    && xbacklight -set 50 -steps 1
    && echo "XSET50OUT" >
/sys/kernel/debug/tracing/trace_marker
sleep 2
echo "XSET100IN" > /sys/kernel/debug/tracing/trace_marker
    && xbacklight -set 100 -steps 1
    && echo "XSET100OUT" >
/sys/kernel/debug/tracing/trace_marker

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20170410/2793003a/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=100446

--- Comment #3 from Carlo Caione <carlo at caione.org> ---
I forgot: the mmiotrace was taken using the proprietary NVIDIA drivers 381.09
(beta). With this version I'm able to change the brightness using
xbacklight.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20170410/c1685ee9/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=100446

--- Comment #4 from Carlo Caione <carlo at caione.org> ---
For the sake of completeness some more info on this.

The two settings differ only for couple of accesses:

< MMIO32 W 0x00d980 0x000000ff PGPIO+0x980 <= 0xff
---
> MMIO32 W 0x00d980 0x0000007f PGPIO+0x980 <= 0x7f
< MMIO32 W 0x619484 0x0000ff00 PDISPLAY.VGA.CR+0x84 <= 0xff00
---
> MMIO32 W 0x619484 0x00007000 PDISPLAY.VGA.CR+0x84 <= 0x7000
The problem is that poking at those registers using nvapeek / nvapoke
doesn't
change the brightness.

Also trying to use nvammiotracereplay to reply step-by-step the mmio trace has
no effect on the brightness.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20170516/156e9247/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=100446

--- Comment #5 from caguduzexi at sharklasers.com ---
I wont recommend using/keeping the GP106 (GTX 1060). It cant ever run with free
software:
https://www.theregister.co.uk/2015/04/15/nvidia_gtx_900_linux_driver_roadbloack/
https://www.phoronix.com/scan.php?page=news_item&px=Nouveau-XDC2017
https://www.phoronix.com/scan.php?page=news_item&px=Nouveau-XDC2016-NVIDIA

Sell this crappy GP102 card (in your case the notebook that contains this crap)
away and go away from nvidia. Nvidia died with the 780ti card. Its the last
end-user card that can be used normaly. Everything else is in some countries
even a legal problem. Because the manufacturer (nvidia) blocks the users from
beeing able to boot the software they want on THEIR hardware - happyly illegal
in some countries. Hopefully some layer would sue the heck out of nvidia so
that they would have to release the private signing key or close their doors.
Blocking the freedom of the users on such way should not be accepted by anyone.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20180129/38b9d950/attachment-0001.html>

https://bugs.freedesktop.org/show_bug.cgi?id=100446

--- Comment #6 from Martin Peres <martin.peres at free.fr> ---
(In reply to caguduzexi from comment #5)
> I wont recommend using/keeping the GP106 (GTX 1060). It cant ever run with
> free software:
> https://www.theregister.co.uk/2015/04/15/
> nvidia_gtx_900_linux_driver_roadbloack/
> https://www.phoronix.com/scan.php?page=news_item&px=Nouveau-XDC2017
>
https://www.phoronix.com/scan.php?page=news_item&px=Nouveau-XDC2016-NVIDIA
> 
> Sell this crappy GP102 card (in your case the notebook that contains this
> crap) away and go away from nvidia. Nvidia died with the 780ti card. Its
the
> last end-user card that can be used normaly. Everything else is in some
> countries even a legal problem. Because the manufacturer (nvidia) blocks
the
> users from beeing able to boot the software they want on THEIR hardware -
> happyly illegal in some countries. Hopefully some layer would sue the heck
> out of nvidia so that they would have to release the private signing key or
> close their doors.
> Blocking the freedom of the users on such way should not be accepted by
> anyone.
User banned

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20180129/9caf4a29/attachment-0001.html>

https://bugs.freedesktop.org/show_bug.cgi?id=100446

--- Comment #7 from Karol Herbst <karolherbst at gmail.com> ---
(In reply to Carlo Caione from comment #4)
> For the sake of completeness some more info on this.
> 
> The two settings differ only for couple of accesses:
> 
> < MMIO32 W 0x00d980 0x000000ff PGPIO+0x980 <= 0xff
> ---
> > MMIO32 W 0x00d980 0x0000007f PGPIO+0x980 <= 0x7f
> 
> < MMIO32 W 0x619484 0x0000ff00 PDISPLAY.VGA.CR+0x84 <= 0xff00
> ---
> > MMIO32 W 0x619484 0x00007000 PDISPLAY.VGA.CR+0x84 <= 0x7000
> 
> The problem is that poking at those registers using nvapeek / nvapoke
> doesn't change the brightness.
> 
> Also trying to use nvammiotracereplay to reply step-by-step the mmio trace
> has no effect on the brightness.
Can you check that this is fixed in 4.16-rc6? A fix landed to address backlight
problems and it might be the same you had:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v4.16-rc6&id=9e75dc61eaa9acd1bff83c3b814ac2af6dc1f64c

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20180322/023ae8e2/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=100446

--- Comment #8 from Pedro Albuquerque Santos <petersaints at gmail.com>
---
I have the same problem on an ASUS GL502VM with a GTX 1060 6GB. UNFORTUNATELY
this laptop shipped with G-SYNC enabled, which means that the Intel GPU is
completely disabled and everything goes through/is controlled by the NVIDIA
GPU. I would rather have no G-SYNC but having the Intel GPU driving the display
output and backlight. I'm sure that it would be a much less painful
experience.

Well... Enough with ranting! Since you suggested that this may have been fixed
by a recent kernel update, I have tested a Fedora 28 Workstation Live Image
that comes with the 4.16rc6 kernel. But the problem persists.
>From what I could understand, even if the 4.16 corrects the underlying
issue,
the nouveau driver still needs to be changed and manually recompiled as
suggested by the OP because backlight support for Pascal-based cards is not
enabled by that switch statement. The "NV_DEVICE_INFO_V0_PASCAL"
clause is
missing in the "nvidia_backlight.c" file. Is this assessment correct?

Also, feel free to ask me for any further information that may help you to
fully support backlight control for Pascal GPUs. I may need some instructions
on how to gather some lower level information, but I'll gladly do it if you
think that it may help.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20180403/f9ce4787/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=100446

--- Comment #9 from Bernhard Rosenkraenzer <bero at lindev.ch> ---
Still happens with 4.16.0 final on an hp omen 17-an0xx laptop.

GPU details from lspci:
01:00.0 0300: 10de:1be1 (rev a1) (prog-if 00 [VGA controller])
        Subsystem: 103c:8393
        Flags: bus master, fast devsel, latency 0, IRQ 132
        Memory at db000000 (32-bit, non-prefetchable) [size=16M]
        Memory at b0000000 (64-bit, prefetchable) [size=256M]
        Memory at c0000000 (64-bit, prefetchable) [size=32M]
        I/O ports at e000 [size=128]
        Expansion ROM at dc000000 [disabled] [size=512K]
        Capabilities: [60] Power Management version 3
        Capabilities: [68] MSI: Enable+ Count=1/1 Maskable- 64bit+
        Capabilities: [78] Express Endpoint, MSI 00
        Capabilities: [100] Virtual Channel
        Capabilities: [250] Latency Tolerance Reporting
        Capabilities: [258] L1 PM Substates
        Capabilities: [128] Power Budgeting <?>
        Capabilities: [420] Advanced Error Reporting
        Capabilities: [600] Vendor Specific Information: ID=0001 Rev=1 Len=024
<?>
        Capabilities: [900] #19
        Kernel driver in use: nouveau
        Kernel modules: nvidiafb, nouveau

Additionally, the display doesn't turn on again after an "xset dpms
force off"
(bug #103383); this may well be related.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20180405/3d57d0a0/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=100446

--- Comment #10 from Bernhard Rosenkraenzer <bero at lindev.ch> ---
Created attachment 138646
  --> https://bugs.freedesktop.org/attachment.cgi?id=138646&action=edit
Proposed fix, relative to 4.16.0

The combination of the fix in 4.16-rc and the hint from the first comment on
the bug did it -- backlight control works (at least on my hp Omen) with this
patch on top of 4.16.0.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20180406/37d7c639/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=100446

Geroge T <reportbug at mailna.biz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |reportbug at mailna.biz

--- Comment #11 from Geroge T <reportbug at mailna.biz> ---
*** Bug 106305 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20180501/d6323995/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=100446

--- Comment #12 from Geroge T <reportbug at mailna.biz> ---
I confirm that adding the line "case NV_DEVICE_INFO_V0_PASCAL:" over
latest
kernel git makes it work on my MSI GT73VR 6RF Titan Pro. Will attach the file
for testing purposes.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20180501/3ebf079d/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=100446

--- Comment #13 from Geroge T <reportbug at mailna.biz> ---
Created attachment 139241
  --> https://bugs.freedesktop.org/attachment.cgi?id=139241&action=edit
nouveau_backlight.c working on msi gt73vr 6rf titan pro

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20180501/5c74c3d5/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=100446

--- Comment #14 from Geroge T <reportbug at mailna.biz> ---
Related?

https://bugzilla.gnome.org/show_bug.cgi?id=688052

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20180505/d5d35328/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=100446

--- Comment #15 from Pedro Albuquerque Santos <petersaints at gmail.com>
---
Any reason why this hasn't been fixed yet given that it seems to be an easy
fix?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20190131/1c7384b7/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=100446

--- Comment #16 from Ilia Mirkin <imirkin at alum.mit.edu> ---
(In reply to Pedro Albuquerque Santos from comment #15)
> Any reason why this hasn't been fixed yet given that it seems to be an
easy
> fix?
This is in Ben's tree now:

https://github.com/skeggsb/nouveau/commit/a9133adc009eb3b982fb27d073e5087e63187b23

And should make its way to kernel 5.1.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20190204/eba580a3/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=100446

--- Comment #17 from Ilia Mirkin <imirkin at alum.mit.edu> ---
Er, make that 5.0. It's in 5.0-rc2.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20190204/3320e43d/attachment.html>

https://bugs.freedesktop.org/show_bug.cgi?id=100446

Ilia Mirkin <imirkin at alum.mit.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20190204/0c4b555f/attachment.html>