Nouveau - Oct 2016 - Acer Aspire V7-582PG (Haswell, GTX 750M) fails to power off GPU via Power Resources

No, there are not. Here is the recursive directory listing:
http://sprunge.us/FIRE

Op do 27 okt. 2016 11:30 schreef Mika Westerberg <
mika.westerberg at linux.intel.com>:
> On Thu, Oct 27, 2016 at 09:15:19AM +0000, Rick Kerkhof wrote:
> >    I can confirm what Peter said, path contains \_SB_.PCI0.RP05 and
> >    power_state contains D3hot.
>
> And there are no power_resources_Dx directories under
> /sys/bus/pci/devices/0000:00:1c.4/firmware_node?
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20161027/3617a181/attachment-0001.html>

On Thu, Oct 27, 2016 at 09:42:28AM +0000, Rick Kerkhof
wrote:
>    No, there are not. Here is the recursive directory listing:
Are you able to try the following patch and send me dmesg (or attach it
to that bug)? It should show if the ACPI core even tries to add those
power resources.

diff --git a/drivers/acpi/power.c b/drivers/acpi/power.c
index fcd4ce6f78d5..af9c3e15dd74 100644
--- a/drivers/acpi/power.c
+++ b/drivers/acpi/power.c
@@ -444,6 +444,9 @@ void acpi_power_add_remove_device(struct acpi_device *adev,
bool add)
 	if (!adev->power.flags.power_resources)
 		return;
 
+	acpi_handle_info(adev->handle, "Adding power resources for %s\n",
+			 dev_name(&adev->dev));
+
 	for (state = ACPI_STATE_D0; state <= ACPI_STATE_D3_HOT; state++)
 		acpi_power_expose_hide(adev,
 				       &adev->power.states[state].resources,

Op do 27 okt. 2016 om 11:59 schreef Mika Westerberg <
mika.westerberg at linux.intel.com>:
> On Thu, Oct 27, 2016 at 09:42:28AM +0000, Rick Kerkhof wrote:
> >    No, there are not. Here is the recursive directory listing:
>
> Are you able to try the following patch and send me dmesg (or attach it
> to that bug)? It should show if the ACPI core even tries to add those
> power resources.
>
> diff --git a/drivers/acpi/power.c b/drivers/acpi/power.c
> index fcd4ce6f78d5..af9c3e15dd74 100644
> --- a/drivers/acpi/power.c
> +++ b/drivers/acpi/power.c
> @@ -444,6 +444,9 @@ void acpi_power_add_remove_device(struct acpi_device
> *adev, bool add)
>         if (!adev->power.flags.power_resources)
>                 return;
>
> +       acpi_handle_info(adev->handle, "Adding power resources for
%s\n",
> +                        dev_name(&adev->dev));
> +
>         for (state = ACPI_STATE_D0; state <= ACPI_STATE_D3_HOT; state++)
>                 acpi_power_expose_hide(adev,
>
>  &adev->power.states[state].resources,
>
Thank you for the patch, I have applied it to the kernel sources but I'm
not sure how to proceed from now on. Should I compile the whole kernel or
can I just build an out-of-tree acpi module?
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<https://lists.freedesktop.org/archives/nouveau/attachments/20161027/b047ecc5/attachment-0001.html>

On Thu, Oct 27, 2016 at 12:55:08PM +0300, Mika Westerberg
wrote:
> On Thu, Oct 27, 2016 at 09:42:28AM +0000, Rick Kerkhof wrote:
> >    No, there are not. Here is the recursive directory listing:
> 
> Are you able to try the following patch and send me dmesg (or attach it
> to that bug)? It should show if the ACPI core even tries to add those
> power resources.
So Rick has tested this patch now on top of 4.8.4 (mainline fails to
boot due to a kbuild issue which I reported elsewhere), but the output
is empty. That seems to indicate that flags.power_resources is unset.

Given that _PS3 exists and is indeed a package with some elements, it
seems that acpi_extract_power_resources is failing. Note that in the
SSDT, the power resource NVP3 was referenced before it was defined,
could that result in this enumeration failure? Relevant SSDT excerpt:

    Scope (\_SB.PCI0.RP05)
    {
        Name (_PR3, Package (0x01)  // _PR3: Power Resources for D3hot
        {
            NVP3
        })
        // ...
    }

    PowerResource (NVP3, 0x00, 0x0000)

Kind regards,
Peter
> diff --git a/drivers/acpi/power.c b/drivers/acpi/power.c
> index fcd4ce6f78d5..af9c3e15dd74 100644
> --- a/drivers/acpi/power.c
> +++ b/drivers/acpi/power.c
> @@ -444,6 +444,9 @@ void acpi_power_add_remove_device(struct acpi_device
*adev, bool add)
>  	if (!adev->power.flags.power_resources)
>  		return;
>  
> +	acpi_handle_info(adev->handle, "Adding power resources for
%s\n",
> +			 dev_name(&adev->dev));
> +
>  	for (state = ACPI_STATE_D0; state <= ACPI_STATE_D3_HOT; state++)
>  		acpi_power_expose_hide(adev,
>  				       &adev->power.states[state].resources,