openssh bugs - Aug 2018 - [Bug 2902] New: Shellcheck reports on ssh-copy-id

https://bugzilla.mindrot.org/show_bug.cgi?id=2902

            Bug ID: 2902
           Summary: Shellcheck reports on ssh-copy-id
           Product: Portable OpenSSH
           Version: 7.7p1
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: ssh-copy-id
          Assignee: unassigned-bugs at mindrot.org
          Reporter: jjelen at redhat.com

Created attachment 3175
  --> https://bugzilla.mindrot.org/attachment.cgi?id=3175&action=edit
proposed patches

Running shellcheck on the ssh-copy-id results in several reports.
Nothing significant that would need immediate attention, but minor
fixes and cleanups:

 * Bogus argument to printf (copy&paste error)
 * It gets confused on the variable initialization on a single line
without single quotes

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2902

Darren Tucker <dtucker at dtucker.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtucker at dtucker.net

--- Comment #1 from Darren Tucker <dtucker at dtucker.net> ---
The upstream for this is http://git.hands.com/ssh-copy-id

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2902

Darren Tucker <dtucker at dtucker.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |phil at hands.com

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2902

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |INVALID
             Status|NEW                         |RESOLVED
                 CC|                            |djm at mindrot.org

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2902

Philip Hands <phil at hands.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|INVALID                     |FIXED

--- Comment #2 from Philip Hands <phil at hands.com> ---
(In reply to Jakub Jelen from comment #0)
> Running shellcheck on the ssh-copy-id results in several reports.
> ...
Thanks for the suggestion -- sorry it took me so long to get to it.

Prompted by this, I've run shellcheck on the latest version, and since
it seemed sensible I've patched things to produce a quiet report.

You can see the result here:

 
https://gitlab.com/phil_hands/ssh-copy-id/-/commit/f0da1a1b7d86a6254d6c234b1560e2cfafe18d58

Cheers, Phil.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2902

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Damien Miller <djm at mindrot.org> ---
closing resolved bugs as of 8.6p1 release

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.