openssh bugs - May 2018 - [Bug 2868] New: Vague error/debug message in src/usr.bin/ssh/key.c

https://bugzilla.mindrot.org/show_bug.cgi?id=2868

            Bug ID: 2868
           Summary: Vague error/debug message in src/usr.bin/ssh/key.c
           Product: Portable OpenSSH
           Version: 7.4p1
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: ssh
          Assignee: unassigned-bugs at mindrot.org
          Reporter: scott_fields at me.com

There are several key load functions that all simply report the
following in src/usr.bin/ssh/key.c:

debug("%s: %s", __func__, ssh_err(r));

or

error("%s: %s", __func__, ssh_err(r));

That's very vague, especially for an error message.

I'm specifically referring to the following functions.

key_load_cert()
key_load_public()
key_load_private()
key_load_private_cert()
key_load_private_type()

Unless there is a reason to not include this, I would find it very
desirable to at least include the file that has the exception being
reported in the debug or error message.

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2868

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WONTFIX
                 CC|                            |djm at mindrot.org
             Status|NEW                         |RESOLVED

--- Comment #1 from Damien Miller <djm at mindrot.org> ---
They key.c functions are deprecated and in the process of being
removed. So those messages will go.

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2868

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from Damien Miller <djm at mindrot.org> ---
closing resolved bugs as of 8.6p1 release

-- 
You are receiving this mail because:
You are watching the assignee of the bug.
You are watching someone on the CC list of the bug.