openssh bugs - Aug 2015 - [Bug 2442] New: comment is not set to the filename for identity files with already entered passphrase

https://bugzilla.mindrot.org/show_bug.cgi?id=2442

            Bug ID: 2442
           Summary: comment is not set to the filename for identity files
                    with already entered passphrase
           Product: Portable OpenSSH
           Version: 6.7p1
          Hardware: Other
                OS: Linux
            Status: NEW
          Severity: minor
          Priority: P5
         Component: ssh-add
          Assignee: unassigned-bugs at mindrot.org
          Reporter: vincent-openssh at vinc17.net

With OpenSSH_6.7p1 under Debian/unstable, when I use ssh-add with
multiple filenames to add several identities at once, the comment is
set to the filename for the first identity, but not for the following
ones. That is, for these additional identities, "ssh-add -L" and
"ssh-add -l" output "rsa w/o comment" instead of the
filename.

I suppose that the cause of this bug is that for these additional
identities, the passphrase was already entered (I use the same one for
each identity) and sshkey_parse_private_pem_fileblob() in sshkey.c sets
the comment to "rsa w/o comment", which is rather uninformative. In
this opposite case, add_file() in ssh-add.c sets the comment with:

        if (comment == NULL)
                comment = xstrdup(filename);

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2442

Vincent Lefevre <vincent-openssh at vinc17.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |DUPLICATE
             Status|NEW                         |RESOLVED
                 CC|                            |vincent-openssh at vinc17.net

--- Comment #1 from Vincent Lefevre <vincent-openssh at vinc17.net> ---
It seems to be very similar to the description in bug 2306, and the
patch would indeed fix the problem.

*** This bug has been marked as a duplicate of bug 2306 ***

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2442

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #2 from Damien Miller <djm at mindrot.org> ---
Set all RESOLVED bugs to CLOSED with release of OpenSSH 7.1

-- 
You are receiving this mail because:
You are watching the assignee of the bug.