openssh bugs - Mar 2015 - [Bug 2369] New: `ssh-keygen -A` errors on RSA1 when building with SSH1 disabled

https://bugzilla.mindrot.org/show_bug.cgi?id=2369

            Bug ID: 2369
           Summary: `ssh-keygen -A` errors on RSA1 when building with SSH1
                    disabled
           Product: Portable OpenSSH
           Version: 6.9p1
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5
         Component: ssh-keygen
          Assignee: unassigned-bugs at mindrot.org
          Reporter: vapier at gentoo.org

sshkey.c:sshkey_private_to_fileblob disables support for RSA1 when SSH1
support has been disabled:
    switch (key->type) {
#ifdef WITH_SSH1
    case KEY_RSA1:
        return sshkey_private_rsa1_to_blob(key, blob,
            passphrase, comment);
#endif /* WITH_SSH1 */

but ssh-keygen.c will still include RSA1:
static void
do_gen_all_hostkeys(struct passwd *pw)
{
    struct {
        char *key_type;
        char *key_type_display;
        char *path;
    } key_types[] = {
        { "rsa1", "RSA1", _PATH_HOST_KEY_FILE },

which leads to runtime errors like:
  ssh-keygen: generating new host keys: RSA1 Saving key
"/etc/ssh/ssh_host_key" failed: unknown or unsupported key type

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2369

Mike Frysinger <vapier at gentoo.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.gentoo.org/sho
                   |                            |w_bug.cgi?id=544078

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2369

--- Comment #1 from Mike Frysinger <vapier at gentoo.org> ---
Created attachment 2574
  --> https://bugzilla.mindrot.org/attachment.cgi?id=2574&action=edit
openssh-6.8_p1-ssh-keygen-no-ssh1.patch

-- 
You are receiving this mail because:
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2369

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |djm at mindrot.org
         Resolution|---                         |FIXED
             Blocks|                            |2360
             Status|NEW                         |RESOLVED

--- Comment #2 from Damien Miller <djm at mindrot.org> ---
Similar patch applied (on master an V_6_8 branches) - it was also wrong
for the !OpenSSL case.

Thanks

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2369

Darren Tucker <dtucker at zip.com.au> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dtucker at zip.com.au
            Version|6.9p1                       |6.8p1

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

https://bugzilla.mindrot.org/show_bug.cgi?id=2369

Damien Miller <djm at mindrot.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Damien Miller <djm at mindrot.org> ---
Set all RESOLVED bugs to CLOSED with release of OpenSSH 7.1

-- 
You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.