llvm dev - Jan 2013 - [LLVMdev] [cfe-dev] RFC: put commit messages in *-commits subject lines?

Yup, I didn't either. I went ahead and hacked up a copy with that change
and am switching it over now.

 - Daniel


On Fri, Jan 25, 2013 at 3:06 PM, Sebastian Pop <spop at codeaurora.org>
wrote:
> Daniel Dunbar wrote:
> > I'm a bit hesitant to just hack up the installed copy of
svnmailer, are
> we
> > sure this patch hasn't been dealt with in an upstream version?
>
> I don't see that change in the last dev version:
> http://storage.perlig.de/svnmailer/svnmailer-1.1.0-dev-r1373.tar.bz2
>
> > > -diff_command = /usr/bin/diff -u -L %(label_from)s -L
%(label_to)s
> > > %(from)s %(to)s
> > > +diff_command = /usr/bin/diff -up -L %(label_from)s -L
%(label_to)s
> > > %(from)s %(to)s
> > >  generate_diffs = add copy modify propchange
> > >
> >
> > I'll go ahead and make this change.
>
> Thanks,
> Sebastian
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted
> by The Linux Foundation
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20130125/a8245c63/attachment.html>

Ok, this is done and seems to work.

As far as Chris's request for getting "key directory" paths into
the commit
message, I thought about working on it, but in the end I'm not sure why we
shouldn't just encourage people to self-tag their leading commit line with
some sort of standard key ([MC], [Target/Mips], whatever).

 - Daniel


On Fri, Jan 25, 2013 at 3:11 PM, Daniel Dunbar <daniel at zuster.org>
wrote:
> Yup, I didn't either. I went ahead and hacked up a copy with that
change
> and am switching it over now.
>
>  - Daniel
>
>
> On Fri, Jan 25, 2013 at 3:06 PM, Sebastian Pop <spop at
codeaurora.org>wrote:
>
>> Daniel Dunbar wrote:
>> > I'm a bit hesitant to just hack up the installed copy of
svnmailer, are
>> we
>> > sure this patch hasn't been dealt with in an upstream version?
>>
>> I don't see that change in the last dev version:
>> http://storage.perlig.de/svnmailer/svnmailer-1.1.0-dev-r1373.tar.bz2
>>
>> > > -diff_command = /usr/bin/diff -u -L %(label_from)s -L
%(label_to)s
>> > > %(from)s %(to)s
>> > > +diff_command = /usr/bin/diff -up -L %(label_from)s -L
%(label_to)s
>> > > %(from)s %(to)s
>> > >  generate_diffs = add copy modify propchange
>> > >
>> >
>> > I'll go ahead and make this change.
>>
>> Thanks,
>> Sebastian
>> --
>> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted
>> by The Linux Foundation
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20130125/4c2976f4/attachment.html>

2013/1/26 Daniel Dunbar <daniel at zuster.org>:
> Ok, this is done and seems to work.
Cool!
> As far as Chris's request for getting "key directory" paths
into the commit
> message, I thought about working on it, but in the end I'm not sure why
we
> shouldn't just encourage people to self-tag their leading commit line
with
> some sort of standard key ([MC], [Target/Mips], whatever).
+1. At least for now, I think it might be redundant to add "key
directories".
We may watch on how better this change would have been.

...Takumi

On 01/26/2013 12:15 AM, Daniel Dunbar wrote:
> Ok, this is done and seems to work.
>
> As far as Chris's request for getting "key directory" paths
into the
> commit message, I thought about working on it, but in the end I'm not
> sure why we shouldn't just encourage people to self-tag their leading
> commit line with some sort of standard key ([MC], [Target/Mips], whatever).
Very nice.

While at that, who can get rid of the [llvm],[cfe-commits], ... 
prefixes? I remember we agreed they just cost screen real estate.

Tobi