llvm dev - Sep 2020 - [cfe-dev] Phabricator -> GitHub PRs?

Renato Golin <rengolin at gmail.com> writes:
>
> Don't they give you the opportunity to amend the commit message, at
least? I vaguely remember it's possible.
>
If you mean "amend" like in "git commit --amend", it's
generally a bad
idea to rewrite repository history that has already been published.

If you mean "amend" the message in the Web UI before merging, then
yes,
they let you change the message, but it's very easy to forget to do
that. It's not a scalable workflow given the size of the LLVM project,
unless there's some automation for it, IMHO.

On Sun, Sep 13, 2020 at 10:39 AM Daniel Martín via cfe-dev <
cfe-dev at lists.llvm.org> wrote:
> Renato Golin <rengolin at gmail.com> writes:
> >
> > Don't they give you the opportunity to amend the commit message,
at
> least? I vaguely remember it's possible.
> >
>
> If you mean "amend" like in "git commit --amend",
it's generally a bad
> idea to rewrite repository history that has already been published.
>
> If you mean "amend" the message in the Web UI before merging,
then yes,
> they let you change the message, but it's very easy to forget to do
> that.
You could even remember, but GitHub's web application (at least when used
with Firefox) could, after failing due to transient connection problems,
revert your message changes. This is in addition to the annoyance of GitHub
pages reloading with outdated state and previously-submitted messages
appearing as being under draft.

> It's not a scalable workflow given the size of the LLVM project,
> unless there's some automation for it, IMHO.
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20200913/9fed00a5/attachment.html>

On Sun, 13 Sep 2020 at 15:51, Hubert Tong <hubert.reinterpretcast at
gmail.com>
wrote:
> If you mean "amend" the message in the Web UI before merging,
then yes,
>> they let you change the message, but it's very easy to forget to do
>> that.
>
>
That's what I meant, yes. "Easy to forget" generally goes away
when you
repeat it enough times.

Also, occasionally forgetting to edit the commit message is not an
egregious thing. It's not like the default message is wrong or anything.

You could even remember, but GitHub's web application (at least when
used
> with Firefox) could, after failing due to transient connection problems,
> revert your message changes. This is in addition to the annoyance of GitHub
> pages reloading with outdated state and previously-submitted messages
> appearing as being under draft.
>
Right, I think this is more of a browser issue than a git issue, but I
agree it does have an effect on the commit message.

I don't think the web page would directly have that effect, so perhaps when
using unstable connections, reverting to use the plain website for merges
would help.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20200913/91bdae54/attachment.html>