Luke Drummond via llvm-dev
2020-Jan-15 18:52 UTC
[llvm-dev] [tablegen] table readability / performance
On Tue Jan 14, 2020 at 8:27 PM, Reid Kleckner wrote:> I don't think there's any technical reason for the current structure.Apparently [this](https://docs.microsoft.com/en-us/cpp/cpp/compiler-limits?view=vs-2019) is a thing. This results in the following delight happening on Visual Studio 2015:> fatal error C1091: compiler limit: string exceeds 65535 bytes in lengthSo maybe another time... All the Best Luke -- Codeplay Software Ltd. Company registered in England and Wales, number: 04567874 Registered office: Regent House, 316 Beulah Hill, London, SE19 3HF
Reid Kleckner via llvm-dev
2020-Jan-15 18:58 UTC
[llvm-dev] [tablegen] table readability / performance
Does the same limitation exist in VS 2017? I think that's our support floor these days: https://llvm.org/docs/GettingStarted.html#host-c-toolchain-both-compiler-and-standard-library One *could* make the tablegen behavior conditional on the compiler, and generate the character arrays for VS, and strings for other compilers. It has the potential to create MSVC only issues, but it seems harmless enough... On Wed, Jan 15, 2020 at 10:52 AM Luke Drummond <luke.drummond at codeplay.com> wrote:> On Tue Jan 14, 2020 at 8:27 PM, Reid Kleckner wrote: > > I don't think there's any technical reason for the current structure. > > Apparently > [this]( > https://docs.microsoft.com/en-us/cpp/cpp/compiler-limits?view=vs-2019) > is a thing. > > This results in the following delight happening on Visual Studio 2015: > > > fatal error C1091: compiler limit: string exceeds 65535 bytes in length > > So maybe another time... > > All the Best > > Luke > -- > Codeplay Software Ltd. > Company registered in England and Wales, number: 04567874 > Registered office: Regent House, 316 Beulah Hill, London, SE19 3HF >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200115/03d56f06/attachment.html>
Luke Drummond via llvm-dev
2020-Jan-15 19:14 UTC
[llvm-dev] [tablegen] table readability / performance
On Wed Jan 15, 2020 at 6:58 PM, Reid Kleckner wrote:> Does the same limitation exist in VS 2017? I think that's our support > floor > these days: > https://llvm.org/docs/GettingStarted.html#host-c-toolchain-both-compiler-and-standard-library >It appears that all releases including the latest 2019 are affected.> > One *could* make the tablegen behavior conditional on the compiler, and > generate the character arrays for VS, and strings for other compilers. > It > has the potential to create MSVC only issues, but it seems harmless > enough...I can't see any current `#ifdef _MSCV_VER` usage in tablegen but I'm happy to besmirch it for this. -- Codeplay Software Ltd. Company registered in England and Wales, number: 04567874 Registered office: Regent House, 316 Beulah Hill, London, SE19 3HF