Then perhaps those opposed could suggest how to use Phabricator/Arcanist so that I don't throw my keyboard through my monitor? -bw On Tue, Jan 7, 2020 at 4:33 PM Finkel, Hal J. <hfinkel at anl.gov> wrote:> > On 1/7/20 6:17 PM, Bill Wendling wrote: > > What was the verdict? Any plans to move? I hate coding anything knowing > that I'll have to use Phabricator. It's like nails on a chalkboard. > > > As you might imagine, not everyone agrees with you. My thoughts on how to > move forward were here: > http://lists.llvm.org/pipermail/llvm-dev/2019-November/136591.html - and > I do think that we should move forward. It will take some work, however. > > -Hal > > > > -bw > > On Tue, Jan 7, 2020 at 4:13 PM Finkel, Hal J. <hfinkel at anl.gov> wrote: > >> >> On 1/7/20 6:03 PM, Bill Wendling via llvm-dev wrote: >> >> Now that we're on GitHub, can we *please* move to GitHub PRs? As much as >> I hate git, I hate Phabricator/Archanist even more. They're super clunky >> and makes working in git that much worse. >> >> >> FYI: We did have a thread on this a couple of months ago: >> http://lists.llvm.org/pipermail/llvm-dev/2019-November/136579.html >> >> -Hal >> >> >> >> -bw >> >> _______________________________________________ >> LLVM Developers mailing listllvm-dev at lists.llvm.orghttps://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev >> >> -- >> Hal Finkel >> Lead, Compiler Technology and Programming Languages >> Leadership Computing Facility >> Argonne National Laboratory >> >> -- > Hal Finkel > Lead, Compiler Technology and Programming Languages > Leadership Computing Facility > Argonne National Laboratory > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200107/6ac0a98e/attachment.html>
Doerfert, Johannes via llvm-dev
2020-Jan-08 00:59 UTC
[llvm-dev] Phabricator -> GitHub PRs?
Hi Bill, On 01/07, Bill Wendling via llvm-dev wrote:> Then perhaps those opposed could suggest how to use Phabricator/Arcanist so > that I don't throw my keyboard through my monitor?Please explain your problems, w/o the hyperbole, so people can actually do that. Thanks, Johannes -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 228 bytes Desc: not available URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200108/ef73413d/attachment.sig>
On Tue, Jan 7, 2020 at 4:59 PM Doerfert, Johannes <jdoerfert at anl.gov> wrote:> Hi Bill, > > On 01/07, Bill Wendling via llvm-dev wrote: > > Then perhaps those opposed could suggest how to use Phabricator/Arcanist > so > > that I don't throw my keyboard through my monitor? > > Please explain your problems, w/o the hyperbole, so people can actually do > that. > > It's not hyperbole, but fine. How do you use it to keep multiple, relatedchanges in order? The interface for reviewing and responding to reviews is horrific, e.g. quoting text from a review is rather bad, the email it sends is badly formatted and hard to read.. How do you make it reasonably useful? Why can't I *easily* relate changes to each other? Why can't I submit through the Phabricator interface, but have to go to the command line, place the change in a new branch, pull to top-of-tree, rebase, and only then push while hoping it doesn't give fail because the tree became out of date? How can I do a rebase through Phabricator? These are only off the top of my head. There are far more problems I've had with them. -bw -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20200107/41c39cd8/attachment-0001.html>
On 2020-01-08, Doerfert, Johannes via llvm-dev wrote:>Hi Bill, > >On 01/07, Bill Wendling via llvm-dev wrote: >> Then perhaps those opposed could suggest how to use Phabricator/Arcanist so >> that I don't throw my keyboard through my monitor? > >Please explain your problems, w/o the hyperbole, so people can actually do that.+1 A list of arguments I extracted from previous discussions. I really hope these points can be improved before we consider the migration. * No diffs in mail - *super* inconvenient. One has to open each pr in browser (or fetch via git etc etc) (https://lists.llvm.org/pipermail/llvm-dev/2019-November/136583.html) 4) Phabricator's ability to see what has changed since the previous time you commented seems to be much more reliable than what Github provides. (https://lists.llvm.org/pipermail/llvm-dev/2019-November/136589.html) In contrast, I regularly find github decides not to load comments, or marks them as resolved before they are (and hides them). I do not wish the quality of LLVM’s codebase to be beholden to the choices github makes around which parts of the discussion to show me. And the issues with subscribing to github issues carry over to subscribing to github pull requests. (https://lists.llvm.org/pipermail/llvm-dev/2019-November/136685.html) The lack of a Herald replacement may be quite serious. There is no good way to subscribe certain topics based on file paths or commit descriptions. (https://lists.llvm.org/pipermail/llvm-dev/2019-November/136608.html)