llvm dev - Jan 2020 - Phabricator -> GitHub PRs?

Now that we're on GitHub, can we *please* move to GitHub PRs? As much as I
hate git, I hate Phabricator/Archanist even more. They're super clunky and
makes working in git that much worse.

-bw
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20200107/e47b7e36/attachment.html>

On 1/7/20 6:03 PM, Bill Wendling via llvm-dev wrote:
Now that we're on GitHub, can we *please* move to GitHub PRs? As much as I
hate git, I hate Phabricator/Archanist even more. They're super clunky and
makes working in git that much worse.


FYI: We did have a thread on this a couple of months ago:
http://lists.llvm.org/pipermail/llvm-dev/2019-November/136579.html

 -Hal


-bw



_______________________________________________
LLVM Developers mailing list
llvm-dev at lists.llvm.org<mailto:llvm-dev at lists.llvm.org>
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev


--
Hal Finkel
Lead, Compiler Technology and Programming Languages
Leadership Computing Facility
Argonne National Laboratory
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20200108/3c2d6c53/attachment.html>

What was the verdict? Any plans to move? I hate coding anything knowing
that I'll have to use Phabricator. It's like nails on a chalkboard.

-bw

On Tue, Jan 7, 2020 at 4:13 PM Finkel, Hal J. <hfinkel at anl.gov> wrote:
>
> On 1/7/20 6:03 PM, Bill Wendling via llvm-dev wrote:
>
> Now that we're on GitHub, can we *please* move to GitHub PRs? As much
as I
> hate git, I hate Phabricator/Archanist even more. They're super clunky
and
> makes working in git that much worse.
>
>
> FYI: We did have a thread on this a couple of months ago:
> http://lists.llvm.org/pipermail/llvm-dev/2019-November/136579.html
>
>  -Hal
>
>
>
> -bw
>
> _______________________________________________
> LLVM Developers mailing listllvm-dev at
lists.llvm.orghttps://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
> --
> Hal Finkel
> Lead, Compiler Technology and Programming Languages
> Leadership Computing Facility
> Argonne National Laboratory
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20200107/29be689e/attachment.html>

On Tue, Jan 07, 2020 at 04:03:08PM -0800, Bill Wendling via cfe-dev
wrote:
> Now that we're on GitHub, can we *please* move to GitHub PRs? As much
as I
> hate git, I hate Phabricator/Archanist even more. They're super clunky
and
> makes working in git that much worse.
Let me give you (and others) a bit food for thoughts on this topic:

https://gregoryszorc.com/blog/2020/01/07/problems-with-pull-requests-and-how-to-fix-them/

I think it covers a good chunk of the pros and cons of using GH PRs vs
Phabricator (or alternatives to Phabricator).

Joerg

Hi,

as a constructive addition to this topic I picked one thing from the long list
of requests that seemed to pop up a lot and contacted the Github Support about
this:

Diffs in emails.

To be fair, I'm not used to reading diffs in emails a lot but I hear that a
lot of people here and also inside of Red Hat are doing so and always look for
that feature in Github, Gerrit, Patchworks, or whatever tool they're using.

I hope nobody feels offended by this step to contact Github support but what
else to do than to forward a request from the community to the one's that
can implement it? Let's try to remain constructive.

Cheers
Konrad 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0xC0A02C32BCB73099.asc
Type: application/pgp-keys
Size: 6429 bytes
Desc: not available
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20200110/28363d7a/attachment.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 899 bytes
Desc: OpenPGP digital signature
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20200110/28363d7a/attachment.sig>

Not intended to be a strong opinion but I prefer Phab as a dedicated
code review tool. In addition to that, it has accumulated quite a
number of differentials making it easy to reference past reviews, as
well as SVN commits that happened before the decision to migrate to
Git was made. While I haven't had excellent experiences with Arcanist
and only used it a few times, I think referencing differentials (in
form of `Differential Revision: ...`) in commit messages is easy
enough without needing a separate tool for it. While I understand the
desire to use Git (and hence the GitHub migration) as a VCS, that
doesn't necessarily translate to positive experiences with GitHub
itself, especially as a code review tool. Phab, in my opinion, can be
used just fine without Arcanist (which uses Phab's Conduit API). I
don't think frustrating experiences with Arcanist necessarily
translate to negative experiences with Phab. I know that some hold a
different opinion, but I think GitHub tries to do too much, but not
necessarily as well as dedicated tools.

On Wed, Jan 8, 2020 at 12:03 AM Bill Wendling via llvm-dev
<llvm-dev at lists.llvm.org> wrote:
>
> Now that we're on GitHub, can we *please* move to GitHub PRs? As much
as I hate git, I hate Phabricator/Archanist even more. They're super clunky
and makes working in git that much worse.
>
> -bw
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev