llvm dev - Nov 2019 - How to trigger builds in Phabricator?

Hi everyone,

In the reviewing system, after a patch is approved, what should be the
following step?

I assume I'll have to make sure the patch hasn't broken anything, before
pushing it, so I'll wan't to run a full build+tests, probably in a
remote
sterile environment (like a jenkins server).

Do we have an integration system like this? Or should I just trust the
build+tests on my machine?

Regardless, I have seen in many reviews (in Phabricator) that *Builds *are
triggered for them, in particular: "*arc lint + arc unit*" and
"*pre-merge
checks*" (which sounds like what I am searching for). What is their use and
how do I trigger them?

Thanks,
Ehud.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20191121/d571b2b9/attachment.html>

Hi Ehud,

the pre-merge tests are in prototype state. Once they are ready for
testing, I'll announce it on the mailing list

On Thu, Nov 21, 2019 at 9:23 AM Ehud Katz via llvm-dev <
llvm-dev at lists.llvm.org> wrote:
> Hi everyone,
>
> In the reviewing system, after a patch is approved, what should be the
> following step?
>
> I assume I'll have to make sure the patch hasn't broken anything,
before
> pushing it, so I'll wan't to run a full build+tests, probably in a
remote
> sterile environment (like a jenkins server).
>
> Do we have an integration system like this? Or should I just trust the
> build+tests on my machine?
>
> Regardless, I have seen in many reviews (in Phabricator) that *Builds *are
> triggered for them, in particular: "*arc lint + arc unit*" and
"*pre-merge
> checks*" (which sounds like what I am searching for). What is their
use
> and how do I trigger them?
>
> Thanks,
> Ehud.
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>

-- 
Best,
Christian
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20191121/c4b08fae/attachment.html>

Unless things have changed lately and I missed something, you can just push the
change and the bots will pick it up automatically. They will send you emails if
it seems like anything is broken.

That being said, before pushing you should do some local tests (e.g. run the lit
tests) as an initial sanity check.

If it breaks anything, the standard process is

1) Revert it with an explanation of why in the commit message. (E.g. “This broke
this bot” with a link to the build log or a simple example.)
2) Fix the breakage
3) Recommit

- Jessica
> On Nov 21, 2019, at 12:23 AM, Ehud Katz via llvm-dev <llvm-dev at
lists.llvm.org> wrote:
> 
> Hi everyone,
> 
> In the reviewing system, after a patch is approved, what should be the
following step?
> 
> I assume I'll have to make sure the patch hasn't broken anything,
before pushing it, so I'll wan't to run a full build+tests, probably in
a remote sterile environment (like a jenkins server).
> 
> Do we have an integration system like this? Or should I just trust the
build+tests on my machine?
> 
> Regardless, I have seen in many reviews (in Phabricator) that Builds are
triggered for them, in particular: "arc lint + arc unit" and
"pre-merge checks" (which sounds like what I am searching for). What
is their use and how do I trigger them?
> 
> Thanks,
> Ehud.
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20191121/470e9d21/attachment.html>

Thanks. I suspected it to be this way.

On Thu, 21 Nov 2019 at 19:29 Jessica Paquette <jpaquette at apple.com>
wrote:
> Unless things have changed lately and I missed something, you can just
> push the change and the bots will pick it up automatically. They will send
> you emails if it seems like anything is broken.
>
> That being said, before pushing you should do some local tests (e.g. run
> the lit tests) as an initial sanity check.
>
> If it breaks anything, the standard process is
>
> 1) Revert it with an explanation of why in the commit message. (E.g. “This
> broke this bot” with a link to the build log or a simple example.)
> 2) Fix the breakage
> 3) Recommit
>
> - Jessica
>
> On Nov 21, 2019, at 12:23 AM, Ehud Katz via llvm-dev <
> llvm-dev at lists.llvm.org> wrote:
>
> Hi everyone,
>
> In the reviewing system, after a patch is approved, what should be the
> following step?
>
> I assume I'll have to make sure the patch hasn't broken anything,
before
> pushing it, so I'll wan't to run a full build+tests, probably in a
remote
> sterile environment (like a jenkins server).
>
> Do we have an integration system like this? Or should I just trust the
> build+tests on my machine?
>
> Regardless, I have seen in many reviews (in Phabricator) that *Builds *are
> triggered for them, in particular: "*arc lint + arc unit*" and
"*pre-merge
> checks*" (which sounds like what I am searching for). What is their
use
> and how do I trigger them?
>
> Thanks,
> Ehud.
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20191122/d36b7495/attachment.html>

Thanks for the update.
What about "arc lint + arc unit"?

On Thu, Nov 21, 2019 at 11:06 AM Christian Kühnel <kuhnel at google.com>
wrote:
> Hi Ehud,
>
> the pre-merge tests are in prototype state. Once they are ready for
> testing, I'll announce it on the mailing list
>
> On Thu, Nov 21, 2019 at 9:23 AM Ehud Katz via llvm-dev <
> llvm-dev at lists.llvm.org> wrote:
>
>> Hi everyone,
>>
>> In the reviewing system, after a patch is approved, what should be the
>> following step?
>>
>> I assume I'll have to make sure the patch hasn't broken
anything, before
>> pushing it, so I'll wan't to run a full build+tests, probably
in a remote
>> sterile environment (like a jenkins server).
>>
>> Do we have an integration system like this? Or should I just trust the
>> build+tests on my machine?
>>
>> Regardless, I have seen in many reviews (in Phabricator) that *Builds
*are
>> triggered for them, in particular: "*arc lint + arc unit*"
and "*pre-merge
>> checks*" (which sounds like what I am searching for). What is
their use
>> and how do I trigger them?
>>
>> Thanks,
>> Ehud.
>> _______________________________________________
>> LLVM Developers mailing list
>> llvm-dev at lists.llvm.org
>> https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>>
>
>
> --
> Best,
> Christian
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20191123/beb4d974/attachment.html>