Stephan Bergmann via llvm-dev
2019-Oct-30 10:09 UTC
[llvm-dev] Comments on GitHub commits?
You can apparently leave comments on GitHub commits (instead of commenting at Phabricator, or directly sending a reply to the relevant commit mailing list and relevant CCs). I once accidentally did that myself (<https://github.com/llvm/llvm-project/commit/4a6861a7e5b59be24a09b8b9782255d028e7aade#commitcomment-35540755>) and now (presumably because I'm member of some GitHub group) got mail about <https://github.com/llvm/llvm-project/commit/2724d9e12960cc1d93eeabbfc9aa1bffffa041cc#commitcomment-35724925>. Do we want to allow such comments? If we do, are intended recipients of such comments (esp. in a case like mine above, where there was no @... in the comment and I intended to reach at least the commit's author) reliably informed about them (i.e., is it guaranteed that they will receive a mail)? If we don't, is there a way to block such comments on GitHub (and give a message about the preferred communication channels)?
On 10/30/2019 03:09 AM, Stephan Bergmann via llvm-dev wrote:> You can apparently leave comments on GitHub commits (instead of commenting at Phabricator, or directly sending a reply to the relevant commit mailing list and relevant CCs). I once accidentally did that myself (<https://github.com/llvm/llvm-project/commit/4a6861a7e5b59be24a09b8b9782255d028e7aade#commitcomment-35540755>) and now (presumably because I'm member of some GitHub group) got mail about <https://github.com/llvm/llvm-project/commit/2724d9e12960cc1d93eeabbfc9aa1bffffa041cc#commitcomment-35724925>. > > Do we want to allow such comments? >I think we would like this disabled, but I don't think it's possible. Or at least I haven't found a way to do it yet. -Tom> If we do, are intended recipients of such comments (esp. in a case like mine above, where there was no @... in the comment and I intended to reach at least the commit's author) reliably informed about them (i.e., is it guaranteed that they will receive a mail)? > > If we don't, is there a way to block such comments on GitHub (and give a message about the preferred communication channels)? >> _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
> On Oct 30, 2019, at 5:57 PM, Tom Stellard via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > On 10/30/2019 03:09 AM, Stephan Bergmann via llvm-dev wrote: >> You can apparently leave comments on GitHub commits (instead of commenting at Phabricator, or directly sending a reply to the relevant commit mailing list and relevant CCs). I once accidentally did that myself (<https://github.com/llvm/llvm-project/commit/4a6861a7e5b59be24a09b8b9782255d028e7aade#commitcomment-35540755 <https://github.com/llvm/llvm-project/commit/4a6861a7e5b59be24a09b8b9782255d028e7aade#commitcomment-35540755>>) and now (presumably because I'm member of some GitHub group) got mail about <https://github.com/llvm/llvm-project/commit/2724d9e12960cc1d93eeabbfc9aa1bffffa041cc#commitcomment-35724925 <https://github.com/llvm/llvm-project/commit/2724d9e12960cc1d93eeabbfc9aa1bffffa041cc#commitcomment-35724925>>. >> >> Do we want to allow such comments? >> > > I think we would like this disabled, but I don't think it's possible. > Or at least I haven't found a way to do it yet.Not automatically as far as I can tell. One can manually “lock the conversation” on a commit but that’s about it. From what I’ve seen on other projects, comments on raw git commits are rare and self-limiting. The only reasonable responses are “okay”, “okay, file a bug”, and “okay, please submit a patch”. I also haven’t verified this, but I suspect only the commit author gets notified, which prevents idle people from piling onto to the conversation. Dave -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20191031/7a27b83c/attachment.html>