Rui Ueyama via llvm-dev
2016-Nov-14 22:01 UTC
[llvm-dev] Highlighting trailing whitespaces on Phab?
I wonder if Phabricator has an ability to highlight trailing whitespaces, because I often find trailing whitespaces after they are submitted. If they were highlighted, they would have been removed before submitting. Does anyone know about this? -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20161114/b71056db/attachment.html>
Mehdi Amini via llvm-dev
2016-Nov-14 22:30 UTC
[llvm-dev] Highlighting trailing whitespaces on Phab?
Hi, clang-format removes them. If you are (like me) likely to forget to run "git clang-format HEAD~” before pushing, adding a pre-commit (or pre-push) hook is helpful. — Mehdi> On Nov 14, 2016, at 2:01 PM, Rui Ueyama via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > I wonder if Phabricator has an ability to highlight trailing whitespaces, because I often find trailing whitespaces after they are submitted. If they were highlighted, they would have been removed before submitting. Does anyone know about this? > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
Rui Ueyama via llvm-dev
2016-Nov-14 22:43 UTC
[llvm-dev] Highlighting trailing whitespaces on Phab?
When I create a patch, I run clang-format-diff, so that's fine. What I want to do is to find trailing whitespaces in others patches. On Mon, Nov 14, 2016 at 2:30 PM, Mehdi Amini <mehdi.amini at apple.com> wrote:> Hi, > > clang-format removes them. > If you are (like me) likely to forget to run "git clang-format HEAD~” > before pushing, adding a pre-commit (or pre-push) hook is helpful. > > — > Mehdi > > > > On Nov 14, 2016, at 2:01 PM, Rui Ueyama via llvm-dev < > llvm-dev at lists.llvm.org> wrote: > > > > I wonder if Phabricator has an ability to highlight trailing > whitespaces, because I often find trailing whitespaces after they are > submitted. If they were highlighted, they would have been removed before > submitting. Does anyone know about this? > > _______________________________________________ > > LLVM Developers mailing list > > llvm-dev at lists.llvm.org > > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev > >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20161114/72d3c352/attachment.html>