Chris Bieneman via llvm-dev
2016-Jan-14 17:38 UTC
[llvm-dev] Building SVN head with CMake - shared libraries?
> On Jan 14, 2016, at 5:18 AM, Dan Liew <dan at su-root.co.uk> wrote: > > On 14 January 2016 at 11:24, David Jones via llvm-dev > <llvm-dev at lists.llvm.org> wrote: >> Thanks - I'll try this tonight. >> >> Assuming it works, should these variables be added to the docs at >> http://llvm.org/docs/CMake.html ? > > Yes.It probably makes sense to add LLVM_BUILD_LLVM_DYLIB, but I would discourage adding BUILD_SHARED_LIBS to that document. BUILD_SHARED_LIBS is rarely what people actually want, and a lot of people gravitate to it because the wording is similar to the autoconf —enable-shared flag.> > We should probably be updating [1] too given that this document talks > exclusively about compiling with the Autoconf/Makefile build system.Yes, we should update that too. I actually have been meaning to put a section up there documenting the Apple Clang packaging because that is almost entirely open source now. I’ll try to get that done this week.> > @Hans @Chris: > > Should the packaging instructions refer to the CMake or > Autoconf/Makefile build system for the LLVM 3.8 release?Maybe, I’ll defer that to Hans. I believe the packaging scripts are on CMake, so we’ve at least gotten that far.> > > [1] http://llvm.org/docs/Packaging.html
Hans Wennborg via llvm-dev
2016-Jan-14 17:43 UTC
[llvm-dev] Building SVN head with CMake - shared libraries?
On Thu, Jan 14, 2016 at 9:38 AM, Chris Bieneman <beanz at apple.com> wrote:> >> On Jan 14, 2016, at 5:18 AM, Dan Liew <dan at su-root.co.uk> wrote: >> >> On 14 January 2016 at 11:24, David Jones via llvm-dev >> <llvm-dev at lists.llvm.org> wrote: >> We should probably be updating [1] too given that this document talks >> exclusively about compiling with the Autoconf/Makefile build system. > > Yes, we should update that too. I actually have been meaning to put a section up there documenting the Apple Clang packaging because that is almost entirely open source now. I’ll try to get that done this week. > >> >> @Hans @Chris: >> >> Should the packaging instructions refer to the CMake or >> Autoconf/Makefile build system for the LLVM 3.8 release? > > Maybe, I’ll defer that to Hans. I believe the packaging scripts are on CMake, so we’ve at least gotten that far.I wasn't even aware of [1] until now. The release packaging script is using CMake since 3.7.>> [1] http://llvm.org/docs/Packaging.html
Mehdi Amini via llvm-dev
2016-Jan-14 19:22 UTC
[llvm-dev] Building SVN head with CMake - shared libraries?
> On Jan 14, 2016, at 9:38 AM, Chris Bieneman via llvm-dev <llvm-dev at lists.llvm.org> wrote: > > >> On Jan 14, 2016, at 5:18 AM, Dan Liew <dan at su-root.co.uk> wrote: >> >> On 14 January 2016 at 11:24, David Jones via llvm-dev >> <llvm-dev at lists.llvm.org> wrote: >>> Thanks - I'll try this tonight. >>> >>> Assuming it works, should these variables be added to the docs at >>> http://llvm.org/docs/CMake.html ? >> >> Yes. > > It probably makes sense to add LLVM_BUILD_LLVM_DYLIB, but I would discourage adding BUILD_SHARED_LIBS to that document. BUILD_SHARED_LIBS is rarely what people actually want, and a lot of people gravitate to it because the wording is similar to the autoconf —enable-shared flag.Considering that BUILD_SHARED_LIBS is rarely what people want, wouldn’t it make sense to document it to explicitly discourage people from using it and avoid them surprising behavior? (By the way, the name is quite tempting to be used wrongly, it would benefit a rename maybe). — Mehdi> >> >> We should probably be updating [1] too given that this document talks >> exclusively about compiling with the Autoconf/Makefile build system. > > Yes, we should update that too. I actually have been meaning to put a section up there documenting the Apple Clang packaging because that is almost entirely open source now. I’ll try to get that done this week. > >> >> @Hans @Chris: >> >> Should the packaging instructions refer to the CMake or >> Autoconf/Makefile build system for the LLVM 3.8 release? > > Maybe, I’ll defer that to Hans. I believe the packaging scripts are on CMake, so we’ve at least gotten that far. > >> >> >> [1] http://llvm.org/docs/Packaging.html > > _______________________________________________ > LLVM Developers mailing list > llvm-dev at lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
Chris Bieneman via llvm-dev
2016-Jan-14 19:31 UTC
[llvm-dev] Building SVN head with CMake - shared libraries?
> On Jan 14, 2016, at 11:22 AM, Mehdi Amini <mehdi.amini at apple.com> wrote: > >> >> On Jan 14, 2016, at 9:38 AM, Chris Bieneman via llvm-dev <llvm-dev at lists.llvm.org> wrote: >> >> >>> On Jan 14, 2016, at 5:18 AM, Dan Liew <dan at su-root.co.uk> wrote: >>> >>> On 14 January 2016 at 11:24, David Jones via llvm-dev >>> <llvm-dev at lists.llvm.org> wrote: >>>> Thanks - I'll try this tonight. >>>> >>>> Assuming it works, should these variables be added to the docs at >>>> http://llvm.org/docs/CMake.html ? >>> >>> Yes. >> >> It probably makes sense to add LLVM_BUILD_LLVM_DYLIB, but I would discourage adding BUILD_SHARED_LIBS to that document. BUILD_SHARED_LIBS is rarely what people actually want, and a lot of people gravitate to it because the wording is similar to the autoconf —enable-shared flag. > > Considering that BUILD_SHARED_LIBS is rarely what people want, wouldn’t it make sense to document it to explicitly discourage people from using it and avoid them surprising behavior?Honestly, I’m not sure *anyone* actually wants that behavior, and I’d kinda like to remove the option entirely.> (By the way, the name is quite tempting to be used wrongly, it would benefit a rename maybe).Yea, at the very least we need a rename. It also violates the ${Project}_* naming convention. -Chris> > — > Mehdi > > > >> >>> >>> We should probably be updating [1] too given that this document talks >>> exclusively about compiling with the Autoconf/Makefile build system. >> >> Yes, we should update that too. I actually have been meaning to put a section up there documenting the Apple Clang packaging because that is almost entirely open source now. I’ll try to get that done this week. >> >>> >>> @Hans @Chris: >>> >>> Should the packaging instructions refer to the CMake or >>> Autoconf/Makefile build system for the LLVM 3.8 release? >> >> Maybe, I’ll defer that to Hans. I believe the packaging scripts are on CMake, so we’ve at least gotten that far. >> >>> >>> >>> [1] http://llvm.org/docs/Packaging.html >> >> _______________________________________________ >> LLVM Developers mailing list >> llvm-dev at lists.llvm.org <mailto:llvm-dev at lists.llvm.org> >> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev <http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev>-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160114/01c9bdca/attachment.html>
Reasonably Related Threads
- Building SVN head with CMake - shared libraries?
- Building SVN head with CMake - shared libraries?
- Building SVN head with CMake - shared libraries?
- Problem with the way BUILD_SHARED_LIBS=ON handled in llvm 3.8
- Problem with the way BUILD_SHARED_LIBS=ON handled in llvm 3.8