llvm dev - Nov 2015 - revision 252902

> On 2015-Nov-05, at 08:31, Aaron Ballman <aaron at aaronballman.com>
wrote:
> 
> On Thu, Nov 5, 2015 at 11:26 AM, James Molloy <james at
jamesmolloy.co.uk> wrote:
>> Ah I see.
>> 
>> I can't think of a way that would help users in any particular way
offhand.
>> I hadn't considered exposing it to clang users - do you think there
is merit
>> in that?
> 
> I would prefer to avoid it, actually. :-D
I agree we should avoid exposing this as a clang attribute (at least to start);
I imagine it would be easy to misuse.

Hi,

OK, great, it sounds like people are happy with this. I'll go ahead and
land the patch.

Cheers,

James

On Thu, 5 Nov 2015 at 17:45 Duncan P. N. Exon Smith <dexonsmith at
apple.com>
wrote:
>
> > On 2015-Nov-05, at 08:31, Aaron Ballman <aaron at
aaronballman.com> wrote:
> >
> > On Thu, Nov 5, 2015 at 11:26 AM, James Molloy <james at
jamesmolloy.co.uk>
> wrote:
> >> Ah I see.
> >>
> >> I can't think of a way that would help users in any particular
way
> offhand.
> >> I hadn't considered exposing it to clang users - do you think
there is
> merit
> >> in that?
> >
> > I would prefer to avoid it, actually. :-D
>
> I agree we should avoid exposing this as a clang attribute (at least to
> start); I imagine it would be easy to misuse.
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20151106/164d62bf/attachment.html>

The test case that you added in this revision fails on several of the 
power buildbots (for example, 
http://lab.llvm.org:8011/builders/clang-ppc64-elf-linux2/builds/20127) 
and also when I build it locally:


FAIL: Clang :: CodeGenCXX/main-norecurse.cpp (2951 of 27722)
******************** TEST 'Clang :: CodeGenCXX/main-norecurse.cpp' 
FAILED ********************
Script:
--
/home/seurer/llvm/build/llvm-test/./bin/clang -cc1 -internal-isystem 
/home/seurer/llvm/build/llvm-test/bin/../lib/clang/3.8.0/include 
-nostdsysteminc -emit-llvm 
/home/seurer/llvm/llvm-test/tools/clang/test/CodeGenCXX/main-norecurse.cpp 
-o - | /home/seurer/llvm/build/llvm-test/./bin/FileCheck 
/home/seurer/llvm/llvm-test/tools/clang/test/CodeGenCXX/main-norecurse.cpp
--
Exit Code: 1

Command Output (stderr):
--
/home/seurer/llvm/llvm-test/tools/clang/test/CodeGenCXX/main-norecurse.cpp:3:11:
error: expected string not found in input
// CHECK: define i{{.*}} @main({{.*}}) #0
           ^
<stdin>:1:1: note: scanning from here
; ModuleID = 
'/home/seurer/llvm/llvm-test/tools/clang/test/CodeGenCXX/main-norecurse.cpp'
^
<stdin>:6:1: note: possible intended match here
define signext i32 @main(i32 signext %argc, i8** %argv) #0 {
^

-- 

-Bill Seurer