llvm dev - Oct 2015 - [PATCH] D12937: [ARM] Handle +t2dsp feature as an ArchExtKind in ARMTargetParser.def

Ping?


-----Original Message-----
From: Artyom Skrobov [mailto:artyom.skrobov at arm.com] 
Sent: 25 September 2015 14:13
To: 'grosbach at apple.com'; tnorthover at apple.com; 'Renato
Golin'; 'James Molloy'
Cc: 'llvmdev at cs.uiuc.edu'
Subject: RE: [PATCH] D12937: [ARM] Handle +t2dsp feature as an ArchExtKind in
ARMTargetParser.def

Hello guys,

(This discussion started on http://reviews.llvm.org/D12937 )

Is there anyone, other than clang, passing "+t2dsp" feature to llvm?

It was introduced by Jim in 2011:
http://llvm.org/viewvc/llvm-project?view=revision&revision=134261

We're about to rename it into "+dsp", but we thought some tools or
scripts might use the historic spelling.

Is anybody aware of any of these?


-----Original Message-----
From: Renato Golin [mailto:renato.golin at linaro.org] 
Sent: 24 September 2015 03:21
To: Artyom Skrobov; Alexandros Lamprineas
Cc: James Molloy; Peter Smith; Amara Emerson; llvm-commits at lists.llvm.org
Subject: Re: [PATCH] D12937: [ARM] Handle +t2dsp feature as an ArchExtKind in
ARMTargetParser.def

rengolin added a comment.

Hi Alexandros,

The patch looks a lot better, thanks!  Did you do a search on who's using
that flag? If this is Darwin, we should ask Darwin folks before we deprecate or
change their flags.  If not, it'd be good to understand who and why, so we
can plan accordingly.

Cheers, 
Renato

On 23 October 2015 at 17:12, Artyom Skrobov <artyom.skrobov at arm.com>
wrote:
> Ping?
Hi Artyom,

Since this is an internal flag, and the new name makes more sense, and
no one seems interested, please go ahead and commit.

If we get worries later, we can always change the name back.

cheers,
--renato