llvm dev - Oct 2015 - Should I worry about test failures in a release?

Hi all,

I checked out everything mentioned in GettingStarted at 
tags/RELEASE_370/final and ran `make -j4 check-all`.
I got three test failures:

     libc++abi :: catch_array_01.pass.cpp
     libc++abi :: catch_function_01.pass.cpp
     libc++abi :: catch_member_function_pointer_01.pass.cpp

Should I worry?

Here are the failures as reported, with the LLVM source directory 
replaced with ... for clarity:

catch_array_01.pass.cpp.exe: 
.../projects/libcxxabi/test/catch_array_01.pass.cpp:25: int main(): 
Assertion `false' failed.

catch_function_01.pass.cpp.exe: 
.../projects/libcxxabi/test/catch_function_01.pass.cpp:34: int main(): 
Assertion `false' failed.

catch_member_function_pointer_01.pass.cpp.exe: 
.../projects/libcxxabi/test/catch_member_function_pointer_01.pass.cpp:44: void 
test1(): Assertion `false' failed.

Regards,
Jo

Am 11.10.2015 um 08:44 schrieb Joachim Durchholz via
llvm-dev:
> catch_array_01.pass.cpp.exe:
> .../projects/libcxxabi/test/catch_array_01.pass.cpp:25: int main():
> Assertion `false' failed.
Oh nevermind.
Since I plan to use LLVM as a backend, not hack on it, I'm not going to 
get much joy out of TRUNK, so I reverted to 3.7.
Which led me to the realization that GettingStarted does not mention 
libcxxabi.

So, I guess I shouldn't worry about test failures in libcxxabi :-)
Sorry for the noise.

Regards,
Jo

On 11 October 2015 at 21:46, Joachim Durchholz via llvm-dev
<llvm-dev at lists.llvm.org> wrote:
> Since I plan to use LLVM as a backend, not hack on it, I'm not going to
get
> much joy out of TRUNK, so I reverted to 3.7.
> Which led me to the realization that GettingStarted does not mention
> libcxxabi.
That depends on what you use. If you use libc++, then you need to
worry about those tests.

Releases are done with the components that are known to work on the
platform. For example, 3.7 was the first that I bundled the sanitizers
for AArch64, since it's the first that we can claim support. I plan to
release libc++ too, once it's stable, even if the example
documentation doesn't explicitly mention it, the test-release.sh
script can build and test it.

Regarding trunk vs release, it depends on what you need. If your
project will use LLVM for a long time (ie. if this is a serious long
term project), then you should follow trunk as closely as possible. If
this is just a trial project, then following a release is better,
because you can focus on your project only and you'll always be able
to build it targeting a specific release in the future, not having to
track which commits off trunk were good.

cheers,
--renato