Davide Italiano via llvm-dev
2015-Sep-10 02:00 UTC
[llvm-dev] macho-dump deprecation/removal plan
With the correct list this time. On Wed, Sep 9, 2015 at 6:59 PM, Davide Italiano <davide at freebsd.org> wrote:> Hi, > in the last month I spent some time implementing the missing MachO > specific features in llvm-readobj, and converting all the remaining > tests that used macho-dump to the new format. > llvm-readobj should have all the functionality that macho-dump had. If > there's something missing, please open a bug and assign to me, I'll > try to do my best to fill the gap. > > That said, I would like to get rid of macho-dump in the near future. > If there are objections, please raise them. If there are not, I would > like to get rid of macho-dump in 1 week time from now. If this seems > to aggressive, please propose a better schedule. > > Thanks, > > -- > Davide-- Davide "There are no solved problems; there are only problems that are more or less solved" -- Henri Poincare
Eric Christopher via llvm-dev
2015-Sep-10 02:23 UTC
[llvm-dev] macho-dump deprecation/removal plan
Any time you'd like. :) On Wed, Sep 9, 2015, 7:01 PM Davide Italiano <davide at freebsd.org> wrote:> With the correct list this time. > > On Wed, Sep 9, 2015 at 6:59 PM, Davide Italiano <davide at freebsd.org> > wrote: > > Hi, > > in the last month I spent some time implementing the missing MachO > > specific features in llvm-readobj, and converting all the remaining > > tests that used macho-dump to the new format. > > llvm-readobj should have all the functionality that macho-dump had. If > > there's something missing, please open a bug and assign to me, I'll > > try to do my best to fill the gap. > > > > That said, I would like to get rid of macho-dump in the near future. > > If there are objections, please raise them. If there are not, I would > > like to get rid of macho-dump in 1 week time from now. If this seems > > to aggressive, please propose a better schedule. > > > > Thanks, > > > > -- > > Davide > > > > -- > Davide > > "There are no solved problems; there are only problems that are more > or less solved" -- Henri Poincare >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150910/8a51bfd8/attachment.html>
Rafael EspĂndola via llvm-dev
2015-Sep-10 13:13 UTC
[llvm-dev] macho-dump deprecation/removal plan
Thank you so much for doing this! On 9 September 2015 at 22:00, Davide Italiano <davide at freebsd.org> wrote:> With the correct list this time. > > On Wed, Sep 9, 2015 at 6:59 PM, Davide Italiano <davide at freebsd.org> wrote: >> Hi, >> in the last month I spent some time implementing the missing MachO >> specific features in llvm-readobj, and converting all the remaining >> tests that used macho-dump to the new format. >> llvm-readobj should have all the functionality that macho-dump had. If >> there's something missing, please open a bug and assign to me, I'll >> try to do my best to fill the gap. >> >> That said, I would like to get rid of macho-dump in the near future. >> If there are objections, please raise them. If there are not, I would >> like to get rid of macho-dump in 1 week time from now. If this seems >> to aggressive, please propose a better schedule. >> >> Thanks, >> >> -- >> Davide > > > > -- > Davide > > "There are no solved problems; there are only problems that are more > or less solved" -- Henri Poincare
Davide Italiano via llvm-dev
2015-Sep-14 19:43 UTC
[llvm-dev] macho-dump deprecation/removal plan
> From: Alex Rosenberg <alexr at ohmantics.com> > Date: September 9, 2015 at 8:41:40 PM PDT > To: Davide Italiano <davide at freebsd.org> > Cc: llvm-commits <llvm-commits at lists.llvm.org>, Rafael Espindola <rafael.espindola at gmail.com>, James Grosbach <grosbach at apple.com>, Eric Christopher <echristo at gmail.com>, Kevin Enderby <enderby at apple.com> > Subject: Re: macho-dump deprecation/removal plan > > I'm happy to reduce the number of tools that reimplement the same concepts when possible. Many thanks for taking this on! > > I do have some reservations about some of the rewritten tests that now use llvm-readobj. Most notably, the CHECK lines are now checking that the dump has not only the correct byte values, but also that the character representation of those byte values renders the same as well. For example, the SectionData elements in r247235. Nothing major to worry about, but I can picture a day where we obey locale differently or something and the rendering changes. > > AlexHi Alex, sorry for the belated answer but my client ate your e-mail. I understand your concerns and I agree with them. I'll change CHECK lines accordingly and send out a review. Do you have any other comments? Thanks, -- Davide "There are no solved problems; there are only problems that are more or less solved" -- Henri Poincare