Hi, I am no longer accepting new patch nominations for the 3.6.1 branches. There are a handful of outstanding patches waiting for approval from code owners, I may still merge these if I get code owner approval before the start of 'official' testing. We had originally planed to start 'official' testing today, however a regression was found in the 3.6 branch, so I would like to delay testing until this is fixed. Here is the regression: https://llvm.org/bugs/show_bug.cgi?id=23407 It looks like this was caused by r236066-r236068. -Tom
On 4 May 2015 at 21:55, Tom Stellard <tom at stellard.net> wrote:> I am no longer accepting new patch nominations for the 3.6.1 branches. > There are a handful of outstanding patches waiting for approval from > code owners, I may still merge these if I get code owner approval before > the start of 'official' testing.Hi Tom, Where's the list? Is there any ARM left?> Here is the regression: https://llvm.org/bugs/show_bug.cgi?id=23407 > It looks like this was caused by r236066-r236068.Is anyone looking at this? The bug is unassigned... Ahmed, can you have a look? LowerCallTo has a comment that worries me: /// FIXME: When all targets are /// migrated to using LowerCall, this hook should be integrated into SDISel. Does that mean if LowerCall is called directly, it won't fix the tail call reusing the stack pointer? Can they be called interchangeably by the same back-end on different occasions? This may well be a red herring, though... cheers, --renato
On Tue, May 05, 2015 at 01:02:57PM +0100, Renato Golin wrote:> On 4 May 2015 at 21:55, Tom Stellard <tom at stellard.net> wrote: > > I am no longer accepting new patch nominations for the 3.6.1 branches. > > There are a handful of outstanding patches waiting for approval from > > code owners, I may still merge these if I get code owner approval before > > the start of 'official' testing. > > Hi Tom, > > Where's the list? Is there any ARM left? > >LLVM: #r232449 Need approval #r232794 Need approval #r233312 Need approval #r235699 Need approval CLANG: # r232579 Need help merging this one. # r228118 Need approval LIBCXX ABI (All need approval): r231839 r231852 r233984 r234254 r236299 None of these appear to be related to ARM.> > Here is the regression: https://llvm.org/bugs/show_bug.cgi?id=23407 > > It looks like this was caused by r236066-r236068. > > Is anyone looking at this? The bug is unassigned... Ahmed, can you have a look? >Not yet, I will try to follow up on this tomorrow.> LowerCallTo has a comment that worries me: > > /// FIXME: When all targets are > /// migrated to using LowerCall, this hook should be integrated into SDISel. > > Does that mean if LowerCall is called directly, it won't fix the tail > call reusing the stack pointer? Can they be called interchangeably by > the same back-end on different occasions? >Not sure, the tests only fail on i386. I can't reproduce on amd64. -Tom> This may well be a red herring, though... > > cheers, > --renato