llvm dev - Apr 2015 - [LLVMdev] [lld][RFC] TargetLayout class removing

Hi Rui, Shankar,

Do we really need empty TargetLayout class? No we have the following hierarchy:

Layout <- DefaultLayout<> <- TargetLayout<> <-
xxxTargetLayout<>

I suggest to remove TargetLayout and rename DefaultLayout to TargetLayout.

Thoughts?

-- 
Simon Atanasyan

I'm wondering if we even need TargetLayout.

DefaultLayout is the only derived class of Layout. TargetLayout is the only
derived class of DefaultLayout. It looks like we can merge Layout,
DefaultLayout and TargetLayout into one.

On Fri, Apr 3, 2015 at 12:36 PM, Simon Atanasyan <simon at atanasyan.com>
wrote:
> Hi Rui, Shankar,
>
> Do we really need empty TargetLayout class? No we have the following
> hierarchy:
>
> Layout <- DefaultLayout<> <- TargetLayout<> <-
xxxTargetLayout<>
>
> I suggest to remove TargetLayout and rename DefaultLayout to TargetLayout.
>
> Thoughts?
>
> --
> Simon Atanasyan
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.llvm.org/pipermail/llvm-dev/attachments/20150403/9703c05b/attachment.html>

On 4/3/2015 2:36 PM, Simon Atanasyan wrote:
> Hi Rui, Shankar,
>
> Do we really need empty TargetLayout class? No we have the following
hierarchy:
>
> Layout <- DefaultLayout<> <- TargetLayout<> <-
xxxTargetLayout<>
>
> I suggest to remove TargetLayout and rename DefaultLayout to TargetLayout.
>
> Thoughts?
>
Agree.

Shankar Easwaran

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the
Linux Foundation

Good point. But I suggest to do that by two steps. First, remove
TargetLayout and rename DefaultLayout to TargetLayout. Second, merge
TargetLayout and Layout. The first step is easy, the second step
generates large diff, requires reviewing etc.

On Fri, Apr 3, 2015 at 10:40 PM, Rui Ueyama <ruiu at google.com>
wrote:
> I'm wondering if we even need TargetLayout.
>
> DefaultLayout is the only derived class of Layout. TargetLayout is the only
> derived class of DefaultLayout. It looks like we can merge Layout,
> DefaultLayout and TargetLayout into one.
>
> On Fri, Apr 3, 2015 at 12:36 PM, Simon Atanasyan <simon at
atanasyan.com>
> wrote:
>>
>> Hi Rui, Shankar,
>>
>> Do we really need empty TargetLayout class? No we have the following
>> hierarchy:
>>
>> Layout <- DefaultLayout<> <- TargetLayout<> <-
xxxTargetLayout<>
>>
>> I suggest to remove TargetLayout and rename DefaultLayout to
TargetLayout.
>>
>> Thoughts?
-- 
Simon Atanasyan