My change 225282 broke an asan test [1], but by the time I got around to trying to revert it, I noticed that the test had started passing. Moreover, it seems to have been "fixed" by 225291 which at least does not seem related to the breakage directly. I'm puzzled now -- is the failing asan test flaky? Should I still revert 225282? Thank you for your time! [1]: http://lab.llvm.org:8011/builders/libcxx-libcxxabi-x86_64-linux-ubuntu-asan/builds/98/steps/test.libcxx/logs/stdio -- Sanjoy
+eric, who introduced the test in r222076. Eric, how does the test fail under asan? Do you expect a leak report? On Tue, Jan 6, 2015 at 3:16 PM, Sanjoy Das <sanjoy at playingwithpointers.com> wrote:> My change 225282 broke an asan test [1], but by the time I got around > to trying to revert it, I noticed that the test had started passing. > Moreover, it seems to have been "fixed" by 225291 which at least does > not seem related to the breakage directly. > > I'm puzzled now -- is the failing asan test flaky? Should I still > revert 225282? > > Thank you for your time! > > [1]: > http://lab.llvm.org:8011/builders/libcxx-libcxxabi-x86_64-linux-ubuntu-asan/builds/98/steps/test.libcxx/logs/stdio > > -- Sanjoy > _______________________________________________ > LLVM Developers mailing list > LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev >-------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150109/411de29c/attachment.html>
Just to note, my change did make an existing bug more likely. The bug is being tracked at http://llvm.org/bugs/show_bug.cgi?id=22179, and I have a fix up for review: http://reviews.llvm.org/D6914 On Fri, Jan 9, 2015 at 6:58 PM, Kostya Serebryany <kcc at google.com> wrote:> +eric, who introduced the test in r222076. > Eric, how does the test fail under asan? > Do you expect a leak report? > > On Tue, Jan 6, 2015 at 3:16 PM, Sanjoy Das <sanjoy at playingwithpointers.com> > wrote: >> >> My change 225282 broke an asan test [1], but by the time I got around >> to trying to revert it, I noticed that the test had started passing. >> Moreover, it seems to have been "fixed" by 225291 which at least does >> not seem related to the breakage directly. >> >> I'm puzzled now -- is the failing asan test flaky? Should I still >> revert 225282? >> >> Thank you for your time! >> >> [1]: >> http://lab.llvm.org:8011/builders/libcxx-libcxxabi-x86_64-linux-ubuntu-asan/builds/98/steps/test.libcxx/logs/stdio >> >> -- Sanjoy >> _______________________________________________ >> LLVM Developers mailing list >> LLVMdev at cs.uiuc.edu http://llvm.cs.uiuc.edu >> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev > >