llvm dev - Sep 2014 - [LLVMdev] Policy for applying fixes to released branches?

Hi,

I was wondering what the policy is for applying fixes to released branches.

In particular I have fix that would be useful to have in LLVM 3.5. I
recently found and fixed a bug [1] in the way CMake files are
generated by the Autoconf/Makefile system and fixed this in r217484.

I figured it would be more sensible to ask about this in a thread
separate from [2] because this is a much more general question.

So what should I do here?

Should I also commit this patch to the branches/release_35 or am I not
allowed to do this and instead should downstream (e.g. Debian, Arch..
etc) just apply the patch when building their packages?

Even if I add the patch to the release branch I don't think most
distributions will get it because they'll probably use the tarballs
which won't have the patch. I'm pretty sure it would be unhelpful
rebuild the tarballs because downstream won't know that they need to
rebuild their packages.

@Sylvestre : IIRC you maintain LLVM Debian packages so I figured your
insight would be helpful.


[1] http://llvm.org/bugs/show_bug.cgi?id=20884
[2] http://lists.cs.uiuc.edu/pipermail/llvmdev/2014-September/076573.html

Thanks,
Dan.

Hi there,

My guess is that such a patch should go into a new dot release becoming 
3.5.1

According to [1], new releases get decided on by the 'release manager', 
I'm not sure who's the current person to contact for that.  Maybe
that's
something we can document somewhere, I tried a quick search on the 
mailinglist but couldn't find it yet.

Cheers,
  Roel

[1] http://llvm.org/docs/HowToReleaseLLVM.html

On 10/09/14 12:57, Dan Liew wrote:
> Hi,
>
> I was wondering what the policy is for applying fixes to released branches.
>
> In particular I have fix that would be useful to have in LLVM 3.5. I
> recently found and fixed a bug [1] in the way CMake files are
> generated by the Autoconf/Makefile system and fixed this in r217484.
>
> I figured it would be more sensible to ask about this in a thread
> separate from [2] because this is a much more general question.
>
> So what should I do here?
>
> Should I also commit this patch to the branches/release_35 or am I not
> allowed to do this and instead should downstream (e.g. Debian, Arch..
> etc) just apply the patch when building their packages?
>
> Even if I add the patch to the release branch I don't think most
> distributions will get it because they'll probably use the tarballs
> which won't have the patch. I'm pretty sure it would be unhelpful
> rebuild the tarballs because downstream won't know that they need to
> rebuild their packages.
>
> @Sylvestre : IIRC you maintain LLVM Debian packages so I figured your
> insight would be helpful.
>
>
> [1] http://llvm.org/bugs/show_bug.cgi?id=20884
> [2] http://lists.cs.uiuc.edu/pipermail/llvmdev/2014-September/076573.html
>
> Thanks,
> Dan.
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>

On 10 September 2014 12:46, Roel Jordans <r.jordans at tue.nl>
wrote:
> Hi there,
>
> My guess is that such a patch should go into a new dot release becoming
> 3.5.1
>
> According to [1], new releases get decided on by the 'release
manager', I'm
> not sure who's the current person to contact for that.
Tom Stellard did the previous 3.4.2 release. I'm not sure if he plans
on doing any 3.5.x releases.

It maybe a bit early to do a 3.5.1 release though.

On 09/10/2014 06:57 AM, Dan Liew wrote:
> Hi,
>
> I was wondering what the policy is for applying fixes to released branches.
>
For 3.4.x, the policy was that release manager (me) was the only one who 
could commit patches to 3.4 branch.  However, for 3.5, I would be in 
favor of allowing anyone to commit patches as long as they meet the 
normal criteria, which is:
1. Approval from code owner
2. Approval from release manager
3. No shared library ABI/API breakages
> In particular I have fix that would be useful to have in LLVM 3.5. I
> recently found and fixed a bug [1] in the way CMake files are
> generated by the Autoconf/Makefile system and fixed this in r217484.
>
If you cc me on the commit email, I will take a look an approve it.

-Tom
> I figured it would be more sensible to ask about this in a thread
> separate from [2] because this is a much more general question.
>
> So what should I do here?
>
> Should I also commit this patch to the branches/release_35 or am I not
> allowed to do this and instead should downstream (e.g. Debian, Arch..
> etc) just apply the patch when building their packages?
>
> Even if I add the patch to the release branch I don't think most
> distributions will get it because they'll probably use the tarballs
> which won't have the patch. I'm pretty sure it would be unhelpful
> rebuild the tarballs because downstream won't know that they need to
> rebuild their packages.
>
> @Sylvestre : IIRC you maintain LLVM Debian packages so I figured your
> insight would be helpful.
>
>
> [1] http://llvm.org/bugs/show_bug.cgi?id=20884
> [2] http://lists.cs.uiuc.edu/pipermail/llvmdev/2014-September/076573.html
>
> Thanks,
> Dan.
>

> If you cc me on the commit email, I will take a look an approve it.
Okay I'll do this now.